[jira] [Comment Edited] (OFBIZ-11593) "entity/list" request is not handled well

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Comment Edited] (OFBIZ-11593) "entity/list" request is not handled well

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-11593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094307#comment-17094307 ]

Rohit Koushal edited comment on OFBIZ-11593 at 4/28/20, 10:17 AM:
------------------------------------------------------------------

Hey [~jleroux],

Commit e4871226249b7c5dcb51931b81bf5cdb79d7810f breaks the some functionality like adding address/update address during Quick Finalize Order. Might be there are some other requests as well which too call in same manner.

!image-2020-04-28-14-22-36-940.png!


was (Author: rohit.koushal):
Hey [~jleroux],

Commit e4871226249b7c5dcb51931b81bf5cdb79d7810f breaks the some functionilty like adding address/update address during Quick Finalize Order. Might be there are some order request as well  which too  call in same manner.

!image-2020-04-28-14-22-36-940.png!

> "entity/list" request is not handled well
> -----------------------------------------
>
>                 Key: OFBIZ-11593
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11593
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework/webtools
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Major
>             Fix For: Upcoming Branch
>
>         Attachments: image-2020-04-28-14-22-36-940.png
>
>
> The "entity/list" request has been put in with OFBIZ-11007. It's used to call the entitymaint view and so is a demo/didactic duplicate of entitymaint request. It's only used in FindGeneric screen (look for the WebtoolsBackToEntityList label). It's problematic because since the CSRF token defense was put in you can no longer filter the entities from the entities list screen, even when the default NoCsrfDefenseStrategy is used. It works if you use the entitymaint request instead.
> Anyway, 2020-01-19 I proposed in OFBIZ-11306 a solution for such cases. It was not used because 2020-02-14 I thought it was no longer needed, but it's necessary for this case, and maybe others not already detected:
> {code:java}
>          if (pathInfo.get(0).indexOf('?') > -1) {
>              return pathInfo.get(0).substring(0, pathInfo.get(0).indexOf('?'));
>          } else {
> -            return pathInfo.get(0);
> +            if (1 < StringUtils.countMatches(path, "/")) {
> +                return pathInfo.get(0) + "/" + pathInfo.get(1);
> +            } else {
> +                return pathInfo.get(0);
> +            }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)