[jira] [Comment Edited] (OFBIZ-11620) The producttests test suite is brooken

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Comment Edited] (OFBIZ-11620) The producttests test suite is brooken

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-11620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099183#comment-17099183 ]

Jacques Le Roux edited comment on OFBIZ-11620 at 5/4/20, 5:55 PM:
------------------------------------------------------------------

The problem in producttests does not come (only? since it trigggered the issue) from here but from [testUpdateProductCategory|https://ci.apache.org/projects/ofbiz/logs/trunk/framework/html/alltests-errors.html] which is related with OFBIZ-10031 and was closed 2 years ago! still weird (I hope date issue as above), I don't close here...yet...



was (Author: jacques.le.roux):
The problem in producttests does not come (only? since it trigggered the issue) from here but from [testUpdateProductCategory|https://ci.apache.org/projects/ofbiz/logs/trunk/framework/html/alltests-errors.html] which is related with OFBIZ-10031 and was closed 2 years later, still weird (I hope date issue as above), I don't close here...yet...


> The producttests test suite is brooken
> --------------------------------------
>
>                 Key: OFBIZ-11620
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11620
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Major
>             Fix For: Upcoming Branch
>
>
> It was initially broken by OFBIZ-9905 so only trunk was concerned. The fix is simple: there should be no space at the beginning of the file.
> But then, when running the test suite, other issues raise. I guess they  were hidden because of the initial issue.
> OFBIZ-10231 introduced 2 issues
> A syntax error:
> {{product.removeRelated("ProductKeyword", product)}}
> instead of
> {{product.removeRelated("ProductKeyword")}}
> A wrong usage of storeByCondition
> I'll soon commit the solutions



--
This message was sent by Atlassian Jira
(v8.3.4#803005)