[jira] [Comment Edited] (OFBIZ-11882) rename a few map files

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159040#comment-17159040 ]

Jacques Le Roux edited comment on OFBIZ-11882 at 7/16/20, 9:10 AM:
-------------------------------------------------------------------

Alex,

You asked me:
{quote}how are the js/css files getting into ofbiz repository?
 there may be a flaw somewhere.
{quote}
And I did not give you the righ answer. I was thinking about code when you asked about the repo.

As you may have seen since, the js/css/map files are modified when we decide to use retire.js:
 [https://cwiki.apache.org/confluence/display/OFBIZ/About+retire.js]

It started with OFBIZ-9269 OFBIZ-9978 is also related, and there have been few more since:
 [https://issues.apache.org/jira/issues/?jql=project%20%3D%20OFBIZ%20AND%20text%20~%20%22retire.js%22]

As you can see, most of the work was done by Aditya (thank you again Aditya! :)). So we need to know how you did the minification [~adityasharma].

I had a look at the map files we have (same in all supported branches, ie R17, R18 and trunk, thanks to our security work with retire.s)
{noformat}
plugins\ecommerce\webapp\ecommerce\js\bootstrap\css

    bootstrap-4.3.1.css.map
    bootstrap-4.3.1.min.css.map
    bootstrap-grid.css.map
    bootstrap-grid.min.css.map
    bootstrap-reboot.css.map
    bootstrap-reboot.min.css.map

plugins\ecommerce\webapp\ecommerce\js\bootstrap\js

    bootstrap-4.3.1.js.map
    bootstrap-4.3.1.min.js.map
    bootstrap.bundle-4.3.1.js.map
    bootstrap.bundle-4.3.1.min.js.map

themes\common-theme\webapp\common\js\jquery\plugins\validate\lib

    jquery.form.min.js.map

themes\common-theme\webapp\common\js\plugins\imagemanagement

    sizzle.min.map
{noformat}

BTW, if we have the maps, should we not get rid of the source files?


was (Author: jacques.le.roux):
Alex,

You asked me:
{quote}how are the js/css files getting into ofbiz repository?
 there may be a flaw somewhere.
{quote}
And I did not give you the righ answer. I was thinking about code when you asked about the repo.

As you may have seen since, the js/css/map files are modified when we decide to use retire.js:
 [https://cwiki.apache.org/confluence/display/OFBIZ/About+retire.js]

It started with OFBIZ-9269 OFBIZ-9978 is also related, and there have been few more since:
 [https://issues.apache.org/jira/issues/?jql=project%20%3D%20OFBIZ%20AND%20text%20~%20%22retire.js%22]

As you can see, most of the work was done by Aditya (thank you again Aditya! :)). So we need to know how you did the minification [~adityasharma].

I had a look at the map files we have
{noformat}
plugins\ecommerce\webapp\ecommerce\js\bootstrap\css

    bootstrap-4.3.1.css.map
    bootstrap-4.3.1.min.css.map
    bootstrap-grid.css.map
    bootstrap-grid.min.css.map
    bootstrap-reboot.css.map
    bootstrap-reboot.min.css.map

plugins\ecommerce\webapp\ecommerce\js\bootstrap\js

    bootstrap-4.3.1.js.map
    bootstrap-4.3.1.min.js.map
    bootstrap.bundle-4.3.1.js.map
    bootstrap.bundle-4.3.1.min.js.map

themes\common-theme\webapp\common\js\jquery\plugins\validate\lib

    jquery.form.min.js.map

themes\common-theme\webapp\common\js\plugins\imagemanagement

    sizzle.min.map
{noformat}
BTW, if we have the maps, should we not get rid of the source files?

> rename a few map files
> ----------------------
>
>                 Key: OFBIZ-11882
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11882
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce
>    Affects Versions: Release Branch 17.12, Trunk
>            Reporter: Alex Bodnaru
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>         Attachments: ecommerce-js.patch, ecommerce-js2.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> tells a few files to be renamed, to suppress warnings in the browser console.

--
This message was sent by Atlassian Jira
(v8.3.4#803005)