[
https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160360#comment-17160360 ]
Jacques Le Roux edited comment on OFBIZ-11882 at 7/18/20, 7:32 AM:
-------------------------------------------------------------------
Thanks Aditya,
This confirms what I supposed initially. It's a CI and ultimately production thing. Users downstream will have to handle their part if they use a CDN or whatnot.
[~alexbodn] will you handle that as you suggested above?:
bq. there's a much shorter way to fix for the mean time. changing only the map file name in each min file. would you accept that?
Could you then provide a patch for all the maps I listed above? TIA :)
I guess the effect will be the same than what is suggested by [
https://developer.mozilla.org/en-US/docs/Tools/Debugger/How_to/Use_a_source_map], quoting developer.mozilla.org)
bq. include a comment in the transformed file, that points to the source map
(?)
BTW I have created an alert at [
https://cwiki.apache.org/confluence/display/OFBIZ/About+retire.js]. We can update it to have only one simple way:
* to comment in our map;
* or in the the transformed (for us minified) file.
was (Author: jacques.le.roux):
Thanks Aditya,
This confirms what I supposed initially. It's a CI and ultimately production thing. Users downstream will have to handle their part if they use a CDN or whatnot.
[~alexbodn] will you handle that as you suggested above?:
bq. there's a much shorter way to fix for the mean time. changing only the map file name in each min file. would you accept that?
Could you then provide a patch for all the maps I listed above? TIA :)
I guess the effect will be the same than what is suggested by [
https://developer.mozilla.org/en-US/docs/Tools/Debugger/How_to/Use_a_source_map] and (quoting developer.mozilla.org):
bq. include a comment in the transformed file, that points to the source map
(?)
BTW I have created an alert at [
https://cwiki.apache.org/confluence/display/OFBIZ/About+retire.js]. We can update it to have only one simple way:
* to comment in our map
* or in the the transformed (for us minified) file
> rename a few map files
> ----------------------
>
> Key: OFBIZ-11882
> URL:
https://issues.apache.org/jira/browse/OFBIZ-11882> Project: OFBiz
> Issue Type: Improvement
> Components: ecommerce
> Affects Versions: Release Branch 17.12, Trunk
> Reporter: Alex Bodnaru
> Assignee: Jacques Le Roux
> Priority: Trivial
> Attachments: ecommerce-js.patch, ecommerce-js2.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> tells a few files to be renamed, to suppress warnings in the browser console.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Locked
