[
https://issues.apache.org/jira/browse/OFBIZ-11883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160597#comment-17160597 ]
Jacques Le Roux edited comment on OFBIZ-11883 at 7/19/20, 1:31 PM:
-------------------------------------------------------------------
Hi Alex,
I'm not against the map files as shows
https://github.com/apache/ofbiz-framework/commit/8dc3609/As I said in OFBIZ-11882:
bq. Users downstream will have to handle their part if they use a CDN or whatnot.
In production you also need to see the source sometimes...
We speak only about OpenLayers here and I could not find the OpenLayers minified files. I was only looking into their names and they don't follow our conventions. They were put in with OFBIZ-10654. We normally have the complete source with a name like the one used by minified files (OpenLayers-5.3.0.css and OpenLayers-5.3.0.js) and something like OpenLayers-5.3.0.min.js for minified ones, hence my confusion :/.
So I guess we are on the same page now. Following your answer above about need of source files, we need now to add the source files and change the names of all the files to get things clear.
was (Author: jacques.le.roux):
Hi Alex,
I'm not against the map files as shows
https://github.com/apache/ofbiz-framework/commit/8dc3609/As I said in OFBIZ-11882:
bq. Users downstream will have to handle their part if they use a CDN or whatnot.
In production you also need to see the source sometimes...
We speak only about OpenLayers here and I could not find the OpenLayers minified files. I was only looking into their names and they don't follow our conventions. They were put in with OFBIZ-10553. We normally have the complete source with a name like the one used by minified files (OpenLayers-5.3.0.css and OpenLayers-5.3.0.js) and something like OpenLayers-5.3.0.min.js for minified ones, hence my confusion :/.
So I guess we are on the same page now. Following your answer above about need of source files, we need now to add the source files and change the names of all the files to get things clear.
> Add missing map for minified OpenLayers js and css
> --------------------------------------------------
>
> Key: OFBIZ-11883
> URL:
https://issues.apache.org/jira/browse/OFBIZ-11883> Project: OFBiz
> Issue Type: Improvement
> Components: themes
> Affects Versions: Release Branch 17.12, Trunk
> Reporter: Alex Bodnaru
> Assignee: Jacques Le Roux
> Priority: Trivial
> Labels: patch-available
> Attachments: ol-map.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> added the missing files for the in browser development.
> they may be downloaded from the openlayers site.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Locked
