[jira] [Comment Edited] (OFBIZ-12233) Plugin not showing in menu due to permission

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344658#comment-17344658 ]

Jacques Le Roux edited comment on OFBIZ-12233 at 5/16/21, 9:53 AM:
-------------------------------------------------------------------

Hi Gaetan,

After loading date from PluginTestSecurityGroupDemoData.xml according to https://markmail.org/message/b6iz7g27xuow4sgr, your patch works for me and does the job since it's only about removing spaces from permissions, as the related comment says:
bq. // trim the permissions (remove spaces)
I confirm that it has no side effects and the plugin does not show in menu w/o.

If you get to https://localhost:8443/plugin-test/control/main you get this error and more in log:
bq. java.lang.IllegalArgumentException: Could not find resource bundle [PluginTestUiLabels] in the locale [fr]
using English instead of French does not change, adding French labels fixes the issue. Maybe we could add French label as default in the plugin template.

There is though one point to check. If you add <<position="28">> to <<<webapp name="plugin-test">> it should be after "Example Ext" that is using <<position="27">>. But it does not, it's just after Scrum which is <<position="22">>. It's obviously not related to your change, certainly more to OFBIZ-12166. With this you may have found another issue, would you mind have a look? Please tell me, if not I'll look at it, TIA...

Just as a note: I wonder if using a hyphen ("-") in the plugin name is not a bit confusing, anyway not a problem.

If nobody objects I'll commit Monday.


was (Author: jacques.le.roux):
Hi Gaetan,

After loading date from PluginTestSecurityGroupDemoData.xml according to https://markmail.org/message/b6iz7g27xuow4sgr, your patch works for me and does the job since it's only about removing spaces from permissions, as the related comment says:
bq. // trim the permissions (remove spaces)
I confirm that it has no side effects and the plugin does not show in menu w/o.

If you get to https://localhost:8443/plugin-test/control/main you get this error and more in log:
bq. java.lang.IllegalArgumentException: Could not find resource bundle [PluginTestUiLabels] in the locale [fr]
using English instead of French does not change, adding French labels fixes the issue. Maybe we could add French label as default in the plugin template.

There is though one point to check. If you add <<position="28">> to <<<webapp name="plugin-test">> it should be after "Example Ext" that is using <<position="27">>. But it does not, it's just after Scrum which is <<position="22">>. It's obviously not related to your change, certainly more to OFBIZ-12166. You may have found another issue, would you mind have a look?

Just as a note: I wonder if using a hyphen ("-") in the plugin name is not a bit confusing, anyway not a problem.

If nobody objects I'll commit Monday.

> Plugin not showing in menu due to permission
> ---------------------------------------------
>
>                 Key: OFBIZ-12233
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-12233
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 18.12, Release Branch 17.12, Upcoming Branch
>         Environment: openjdk 11.0.11 2021-04-20
> OpenJDK Runtime Environment (build 11.0.11+9-Ubuntu-0ubuntu2.20.04)
> OpenJDK 64-Bit Server VM (build 11.0.11+9-Ubuntu-0ubuntu2.20.04, mixed mode, sharing)
> Ubuntu 20.04.2 LTS
>            Reporter: Gaetan Chaboussie
>            Priority: Minor
>         Attachments: OFBIZ-12233.patch
>
>
> When creating a plugin via gradle :
> {code}
> ./gradlew createPlugin -PpluginId=plugin-test -PpluginResourceName=PluginTest -PwebappName=plugin-test -PbasePermission=PLUGIN_TEST
> {code}
> and loading all the required data and permissions, the plugin doesn"t appear in the menu.
> I think it comes from the ComponentConfig.java file, L1229, when the permissions gets trimmed and modified. Are those lines still useful ? 
> I tried removing it locally and it fixed the problem.

--
This message was sent by Atlassian Jira
(v8.3.4#803005)