[jira] [Comment Edited] (OFBIZ-1319) Split javascript files to have more generic ones includable in all screens, and the more specific ones included more locally

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Comment Edited] (OFBIZ-1319) Split javascript files to have more generic ones includable in all screens, and the more specific ones included more locally

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983046#comment-12983046 ]

Jacques Le Roux edited comment on OFBIZ-1319 at 6/24/16 10:15 PM:
------------------------------------------------------------------

Adrian, I guess you already read my comments about that in the related tasks I just closed. But for those interested and record fo the future here is a summary:

There are 444 calls of <a href="javascript: in FTL files. Not all are mandatory (for instance you don't need a lookup to fill a field, same for calendar). But I doubt that in certain cases you can seriously do it without lookups for instance. For security reasons there are 248 actions which needs javascript: in FTL files (ie javascript is mandatory for those actions to work). Just look for <a href="javascript:document. in *.ftl...

There are 1353 occurences of the word javascript at all in FTL files, 343 in XML files but I think it's rarely mandatory there.

So I really think it's now wishful thinking to hope using OFBIz w/out js enabled, 248 impossible and needed actions can't be forgotten. See OFBIZ-2330 to know more...



was (Author: jacques.le.roux):
Adrian, I guess you already read my comments about that in the related tasks I just closed. But for those interesed and record fo the future here is a summary:

There are 444 calls of <a href="javascript: in FTL files. Not all are mandatory (for instance you don't need a lookup to fill a field, same for calendar). But I doubt that in certain cases you can seriously do it without lookups for instance. For security reasons there are 248 actions which needs javascript: in FTL files (ie javascript is mandatory for those actions to work). Just look for <a href="javascript:document. in *.ftl...

There are 1353 occurences of the word javascript at all in FTL files, 343 in XML files but I think it's rarely mandatory there.

So I really think it's now wishful thinking to hope using OFBIz w/out js enabled, 248 impossible and needed actions can't be forgotten. See OFBIZ-2330 to know more...


> Split javascript files to have more generic ones includable in all screens, and the more specific ones included more locally
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1319
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1319
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>
> From a David's E. Jones comment on ML :
> We should split up javascript files to have the more generic ones includable in all screens, and the more specific ones (like the toggle* and selectAll* methods in there) into a file that can be included more locally.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)