[jira] [Comment Edited] (OFBIZ-5194) ConcurrentModificationException when cancelling an order

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-5194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13770624#comment-13770624 ]

Jacques Le Roux edited comment on OFBIZ-5194 at 9/18/13 10:25 AM:
------------------------------------------------------------------

* What we had before the change:
** get cancelled promo items
** remove them from the list of items

So we got all items but cancelled promo items
* What we have now:
Get non-promo items *AND* non-cancelled items  (or as said Scott "get all non-promo items that aren't cancelled")
* What you suggest:
Get non-promo items *OR* non-cancelled items (if re-phrase what you suggest: get all non-promo items and add to them all the non-cancelled ones)

You are right! Currently we miss the promo items which are not cancelled and the non-promo items which are cancelled

Pfew... the exclusive reasoning is here quite easier than the inclusive one!

               
      was (Author: jacques.le.roux):
    * What we had before the change:
# get cancelled promo Items
# remove them from the list of promo Items
So we get all items but cancelled promo Items
* What we have now:
Get non promo item and non cancelled item  (or as said Scott "get all non-promo items that aren't cancelled")
* What you suggest:
Get non promo item or non cancelled item

                 

> ConcurrentModificationException when cancelling an order
> --------------------------------------------------------
>
>                 Key: OFBIZ-5194
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5194
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Jonatan Soto
>            Assignee: Jacques Le Roux
>            Priority: Blocker
>             Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04
>
>         Attachments: OFBIZ-5194.patch, patch.txt, patch.txt
>
>   Original Estimate: 1m
>  Remaining Estimate: 1m
>
> After the order gets cancelled, there is a loop in OrderView.groovy@122 that removes promotional order line items retrieved from the OrderReadHelper class when cancelled. This is what makes the ConcurrentModificationException to be thrown.
> For further details, check out the following thread at the dev mailing list: http://ofbiz.markmail.org/message/vmm65cmbf5hkmqm6?page=2

... [show rest of quote]

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira