[jira] [Comment Edited] (OFBIZ-5224) In productionrun when failIfItemsAreNotAvailable=N an error is generated and production run stops

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Comment Edited] (OFBIZ-5224) In productionrun when failIfItemsAreNotAvailable=N an error is generated and production run stops

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-5224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13684113#comment-13684113 ]

Jacques Le Roux edited comment on OFBIZ-5224 at 6/15/13 8:32 AM:
-----------------------------------------------------------------

I believe Jacopo had a good reason to change, so better to keep his change. So I'd use this patch rather

{code}
Index: applications/manufacturing/script/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.xml
===================================================================
--- applications/manufacturing/script/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.xml (revision 1492968)
+++ applications/manufacturing/script/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.xml (working copy)
@@ -160,6 +160,9 @@
                     <condition>
                         <or>
                             <if-empty field="parameters.failIfItemsAreNotOnHand"/>
+                            <or>
+                                <if-compare field="parameters.failIfItemsAreNotAvailable" operator="equals" value="Y" type="String"/>
+                            </or>
                             <if-compare field="parameters.failIfItemsAreNotOnHand" operator="equals" value="Y" type="String"/>
                         </or>
                     </condition>
{code}
               
      was (Author: jacques.le.roux):
    I believe Jacopo had good reason to change, so better to keep his change. So I'd use this patch rather

{code}
Index: applications/manufacturing/script/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.xml
===================================================================
--- applications/manufacturing/script/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.xml (revision 1492968)
+++ applications/manufacturing/script/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.xml (working copy)
@@ -160,6 +160,9 @@
                     <condition>
                         <or>
                             <if-empty field="parameters.failIfItemsAreNotOnHand"/>
+                            <or>
+                                <if-compare field="parameters.failIfItemsAreNotAvailable" operator="equals" value="Y" type="String"/>
+                            </or>
                             <if-compare field="parameters.failIfItemsAreNotOnHand" operator="equals" value="Y" type="String"/>
                         </or>
                     </condition>
{code}
                 

> In productionrun when failIfItemsAreNotAvailable=N an error is generated and production run stops
> -------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-5224
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5224
>             Project: OFBiz
>          Issue Type: Bug
>          Components: manufacturing
>    Affects Versions: SVN trunk
>            Reporter: Pierre Smits
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-5224-MFG-ProductionRunServices.patch
>
>
> In a production run there is the possibility to continue even when inventory of a component is not equal to the quantity required. This is done in the section 'Materials Required By The Running Task' by setting the paramater 'failIfItemsAreNotAvailable' to 'N'.
> However, when doing so the production run doesn't continue and generates the error:
> The Following Errors Occurred:
> Error:<br/> Materials Not Available in Warehouse CPU-586: 33 <br/> Error trying to begin transaction, could not process method: The current transaction is marked for rollback, not beginning a new transaction and aborting current operation; the rollbackOnly was caused by: Error in simple-method [Issues the Inventory for a Production Run Task Component [file:/ofbiz-trunk/applications/manufacturing/script/org/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.xml#issueProductionRunTaskComponent]]: ; [Materials Not Available in Warehouse CPU-586: 33] <br/> <br/>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira