[jira] [Comment Edited] (OFBIZ-5308) If you clear the last packed item from from a shipment with two items and then complete the pack, you get the exception below

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-5308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13772034#comment-13772034 ]

Jacques Le Roux edited comment on OFBIZ-5308 at 9/20/13 8:52 AM:
-----------------------------------------------------------------

== TYPOS ==
Karim Rahimpur, the path author (OFBIZ-2163)  did not answer. But by analogy with clearAllLines() method, I decided that packageSeq should not be less than 1!

To be backported after OFBIZ-4794
               
      was (Author: jacques.le.roux):
    == TYPO ==
Karim Rahimpur, the path author (OFBIZ-2163)  did not answer. But by analogy with clearAllLines() method, I decided that packageSeq should not be less that 1!

To be backported after OFBIZ-4794
                 

> If you clear the last packed item from from a shipment with two items and then complete the pack, you get the exception below
> -----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-5308
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5308
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: Release Branch 11.04, SVN trunk, Release Branch 12.04, Release Branch 13.07
>         Environment: All
>            Reporter: Skip Dever
>            Assignee: Jacques Le Roux
>            Priority: Minor
>
> If you clear the last packed item from from a shipment with two items and then complete the pack, you get the exception below:
> Exception thrown while creating the "newEntity" ....ShipmentPackageContent ... Key ... is not present in table shipment_package
> This is happening because org.ofbiz.shipment.packing.PackingSession.clearLine() around line 600 is decrementing packageSeq from 1 to zero.  This causes createPackages() to not generate any ShipmentPackages because of the for statement on packageSeq and therefore the subsequent exception.
> I fixed this by just commenting out the block starting with "if(line.packageSeq ==".  I did not submit a patch because I do not fully understand the logic and do not have time now to learn it now.
> Hopefully the author will be better equipped to deal with it properly.
> Skip

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira