[jira] [Comment Edited] (OFBIZ-5330) trivial error correction to fieldlookup.js

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Comment Edited] (OFBIZ-5330) trivial error correction to fieldlookup.js

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-5330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13778782#comment-13778782 ]

Leon edited comment on OFBIZ-5330 at 9/26/13 1:47 PM:
------------------------------------------------------

hi, Pierre,

"Set the background to yellow" is not the feature brought by this patch, it exists there for long time.

Anyway you're right. It's better to use css class instead of hard-code color.
               
      was (Author: utcb):
    "Set the background to yellow" is not the feature brought by this patch, it exists there for long time.
                 

> trivial error correction to fieldlookup.js
> ------------------------------------------
>
>                 Key: OFBIZ-5330
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5330
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-5330.patch
>
>
> correct following trivial issues:
> 1. in lookupDescriptionLoaded.prototype.update, not assign the form when try to get filed object by its name
> 2. in setSourceColor, variable "target" should be given parameter "src"
> please see attached patch file for details.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira