[jira] [Comment Edited] (OFBIZ-5631) service getFxConversion is never used

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Comment Edited] (OFBIZ-5631) service getFxConversion is never used

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-5631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14177813#comment-14177813 ]

Hans Bakker edited comment on OFBIZ-5631 at 10/21/14 1:46 AM:
--------------------------------------------------------------

Just because that the service is not used in the standard ERP application is not a reason to remove. If the E-commerce would have the automatic price conversion in different exchange rates, you would use this service.

There are much more services and entity views created which are not used but try to solve common world problems

If you would have looked a bit further you can see that it is not so easy to get the exchange rate conversion function used  and that is why the service was created.

I suggest to keep it.

Regards,'Hans


was (Author: hansbak):
Just because that the service is not used in the standard ERP application is not a reason to remove. If the E-commerce would have the automatic price conversion in different exchange rates, you would use this service.

If you would have looked a bit further you can see that it is not so easy to get the exchange rate conversion function used  and that is why the service was created.

I suggest to keep it.

Regards,'Hans

> service getFxConversion is never used
> -------------------------------------
>
>                 Key: OFBIZ-5631
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5631
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: Trunk
>            Reporter: Pierre Smits
>            Assignee: Hans Bakker
>            Priority: Minor
>
> service getFxConversion got incorporated in r891159.
> However, it is not used anywhere.
> I propose to remove it as part of the trim down effort



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)