[jira] [Comment Edited] (OFBIZ-5962) If orderDecimalQuantity set to N then system should return error if user add partial quantity in order

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Comment Edited] (OFBIZ-5962) If orderDecimalQuantity set to N then system should return error if user add partial quantity in order

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-5962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14279866#comment-14279866 ]

Deepak Dixit edited comment on OFBIZ-5962 at 1/16/15 6:28 AM:
--------------------------------------------------------------

While fixing this issue found that orderDecimalQuantity check is missing while add item to order and update order item flow. I'll add these check as well for add item and update order flow.


was (Author: deepak.dixit):
While fixing this issue found that orderDecimalQuantity check is missing while add item to cart and update order item flow. I'll add these check as well for add item and update order flow.

> If orderDecimalQuantity set to N then system should return error if user add partial quantity in order
> ------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-5962
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5962
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 13.07, Trunk, 14.12.01
>            Reporter: Deepak Dixit
>            Assignee: Jacques Le Roux
>
> If productStore.orderDecimalQuantity and product.orderDecimalQuantity is set to N, then system should return error if we try to add to partial quantity then system should return error instead of rounding it to 0,
> Actual Behavior: If partial quantity not allowed in in order process, and user enter 1.5 quantity then it rounded it and add 2 quantity.
> Expected Behavior: if partial quantity not allowed then system should return error instead of doing rounding if partial quantity passed during add/update item.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Reply | Threaded
Open this post in threaded view
|

Re: [jira] [Comment Edited] (OFBIZ-5962) If orderDecimalQuantity set to N then system should return error if user add partial quantity in order

Robert Lasater-2
After a new product item is created, the option to change this setting is
no longer visible. Is there a reason for hiding it? or is it a bug?



On Thu, Jan 15, 2015 at 11:28 PM, Deepak Dixit (JIRA) <[hidden email]>
wrote:

>
>     [
> https://issues.apache.org/jira/browse/OFBIZ-5962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14279866#comment-14279866
> ]
>
> Deepak Dixit edited comment on OFBIZ-5962 at 1/16/15 6:28 AM:
> --------------------------------------------------------------
>
> While fixing this issue found that orderDecimalQuantity check is missing
> while add item to order and update order item flow. I'll add these check as
> well for add item and update order flow.
>
>
> was (Author: deepak.dixit):
> While fixing this issue found that orderDecimalQuantity check is missing
> while add item to cart and update order item flow. I'll add these check as
> well for add item and update order flow.
>
> > If orderDecimalQuantity set to N then system should return error if user
> add partial quantity in order
> >
> ------------------------------------------------------------------------------------------------------
> >
> >                 Key: OFBIZ-5962
> >                 URL: https://issues.apache.org/jira/browse/OFBIZ-5962
> >             Project: OFBiz
> >          Issue Type: Bug
> >          Components: order
> >    Affects Versions: Release Branch 13.07, Trunk, 14.12.01
> >            Reporter: Deepak Dixit
> >            Assignee: Jacques Le Roux
> >
> > If productStore.orderDecimalQuantity and product.orderDecimalQuantity is
> set to N, then system should return error if we try to add to partial
> quantity then system should return error instead of rounding it to 0,
> > Actual Behavior: If partial quantity not allowed in in order process,
> and user enter 1.5 quantity then it rounded it and add 2 quantity.
> > Expected Behavior: if partial quantity not allowed then system should
> return error instead of doing rounding if partial quantity passed during
> add/update item.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
>
Reply | Threaded
Open this post in threaded view
|

Re: [jira] [Comment Edited] (OFBIZ-5962) If orderDecimalQuantity set to N then system should return error if user add partial quantity in order

Jacques Le Roux
Administrator
Le 16/01/2015 07:44, Robert Lasater a écrit :
> After a new product item is created,
What is a "new product item" ?
> the option to change this setting is
> no longer visible.
I guess you mean in the product store setting? I can't see any relation with a product

Jacques

> Is there a reason for hiding it? or is it a bug?
>
>
>
> On Thu, Jan 15, 2015 at 11:28 PM, Deepak Dixit (JIRA) <[hidden email]>
> wrote:
>
>>      [
>> https://issues.apache.org/jira/browse/OFBIZ-5962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14279866#comment-14279866
>> ]
>>
>> Deepak Dixit edited comment on OFBIZ-5962 at 1/16/15 6:28 AM:
>> --------------------------------------------------------------
>>
>> While fixing this issue found that orderDecimalQuantity check is missing
>> while add item to order and update order item flow. I'll add these check as
>> well for add item and update order flow.
>>
>>
>> was (Author: deepak.dixit):
>> While fixing this issue found that orderDecimalQuantity check is missing
>> while add item to cart and update order item flow. I'll add these check as
>> well for add item and update order flow.
>>
>>> If orderDecimalQuantity set to N then system should return error if user
>> add partial quantity in order
>> ------------------------------------------------------------------------------------------------------
>>>                  Key: OFBIZ-5962
>>>                  URL: https://issues.apache.org/jira/browse/OFBIZ-5962
>>>              Project: OFBiz
>>>           Issue Type: Bug
>>>           Components: order
>>>     Affects Versions: Release Branch 13.07, Trunk, 14.12.01
>>>             Reporter: Deepak Dixit
>>>             Assignee: Jacques Le Roux
>>>
>>> If productStore.orderDecimalQuantity and product.orderDecimalQuantity is
>> set to N, then system should return error if we try to add to partial
>> quantity then system should return error instead of rounding it to 0,
>>> Actual Behavior: If partial quantity not allowed in in order process,
>> and user enter 1.5 quantity then it rounded it and add 2 quantity.
>>> Expected Behavior: if partial quantity not allowed then system should
>> return error instead of doing rounding if partial quantity passed during
>> add/update item.
>>
>>
>>
>> --
>> This message was sent by Atlassian JIRA
>> (v6.3.4#6332)
>>
Reply | Threaded
Open this post in threaded view
|

Re: [jira] [Comment Edited] (OFBIZ-5962) If orderDecimalQuantity set to N then system should return error if user add partial quantity in order

Deepak Dixit-2
I think Robert is talking about edit product screen. As we have orderDecimalQuantity field in product entity but we don’t have option to set it vie EditProduct screen.

Thanks & Regards

Deepak Dixit

> On Jan 16, 2015, at 6:00 PM, Jacques Le Roux <[hidden email]> wrote:
>
> Le 16/01/2015 07:44, Robert Lasater a écrit :
>> After a new product item is created,
> What is a "new product item" ?
>> the option to change this setting is
>> no longer visible.
> I guess you mean in the product store setting? I can't see any relation with a product
>
> Jacques
>> Is there a reason for hiding it? or is it a bug?
>>
>>
>>
>> On Thu, Jan 15, 2015 at 11:28 PM, Deepak Dixit (JIRA) <[hidden email]>
>> wrote:
>>
>>>     [
>>> https://issues.apache.org/jira/browse/OFBIZ-5962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14279866#comment-14279866
>>> ]
>>>
>>> Deepak Dixit edited comment on OFBIZ-5962 at 1/16/15 6:28 AM:
>>> --------------------------------------------------------------
>>>
>>> While fixing this issue found that orderDecimalQuantity check is missing
>>> while add item to order and update order item flow. I'll add these check as
>>> well for add item and update order flow.
>>>
>>>
>>> was (Author: deepak.dixit):
>>> While fixing this issue found that orderDecimalQuantity check is missing
>>> while add item to cart and update order item flow. I'll add these check as
>>> well for add item and update order flow.
>>>
>>>> If orderDecimalQuantity set to N then system should return error if user
>>> add partial quantity in order
>>> ------------------------------------------------------------------------------------------------------
>>>>                 Key: OFBIZ-5962
>>>>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5962
>>>>             Project: OFBiz
>>>>          Issue Type: Bug
>>>>          Components: order
>>>>    Affects Versions: Release Branch 13.07, Trunk, 14.12.01
>>>>            Reporter: Deepak Dixit
>>>>            Assignee: Jacques Le Roux
>>>>
>>>> If productStore.orderDecimalQuantity and product.orderDecimalQuantity is
>>> set to N, then system should return error if we try to add to partial
>>> quantity then system should return error instead of rounding it to 0,
>>>> Actual Behavior: If partial quantity not allowed in in order process,
>>> and user enter 1.5 quantity then it rounded it and add 2 quantity.
>>>> Expected Behavior: if partial quantity not allowed then system should
>>> return error instead of doing rounding if partial quantity passed during
>>> add/update item.
>>>
>>>
>>>
>>> --
>>> This message was sent by Atlassian JIRA
>>> (v6.3.4#6332)
>>>


smime.p7s (6K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [jira] [Comment Edited] (OFBIZ-5962) If orderDecimalQuantity set to N then system should return error if user add partial quantity in order

Jacques Le Roux
Administrator
Thanks Deepak,

Then, should we not open another Jira for that?

Jacques

Le 16/01/2015 13:48, Deepak Dixit a écrit :

> I think Robert is talking about edit product screen. As we have orderDecimalQuantity field in product entity but we don’t have option to set it vie EditProduct screen.
>
> Thanks & Regards
> —
> Deepak Dixit
>
>> On Jan 16, 2015, at 6:00 PM, Jacques Le Roux <[hidden email]> wrote:
>>
>> Le 16/01/2015 07:44, Robert Lasater a écrit :
>>> After a new product item is created,
>> What is a "new product item" ?
>>> the option to change this setting is
>>> no longer visible.
>> I guess you mean in the product store setting? I can't see any relation with a product
>>
>> Jacques
>>> Is there a reason for hiding it? or is it a bug?
>>>
>>>
>>>
>>> On Thu, Jan 15, 2015 at 11:28 PM, Deepak Dixit (JIRA) <[hidden email]>
>>> wrote:
>>>
>>>>      [
>>>> https://issues.apache.org/jira/browse/OFBIZ-5962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14279866#comment-14279866
>>>> ]
>>>>
>>>> Deepak Dixit edited comment on OFBIZ-5962 at 1/16/15 6:28 AM:
>>>> --------------------------------------------------------------
>>>>
>>>> While fixing this issue found that orderDecimalQuantity check is missing
>>>> while add item to order and update order item flow. I'll add these check as
>>>> well for add item and update order flow.
>>>>
>>>>
>>>> was (Author: deepak.dixit):
>>>> While fixing this issue found that orderDecimalQuantity check is missing
>>>> while add item to cart and update order item flow. I'll add these check as
>>>> well for add item and update order flow.
>>>>
>>>>> If orderDecimalQuantity set to N then system should return error if user
>>>> add partial quantity in order
>>>> ------------------------------------------------------------------------------------------------------
>>>>>                  Key: OFBIZ-5962
>>>>>                  URL: https://issues.apache.org/jira/browse/OFBIZ-5962
>>>>>              Project: OFBiz
>>>>>           Issue Type: Bug
>>>>>           Components: order
>>>>>     Affects Versions: Release Branch 13.07, Trunk, 14.12.01
>>>>>             Reporter: Deepak Dixit
>>>>>             Assignee: Jacques Le Roux
>>>>>
>>>>> If productStore.orderDecimalQuantity and product.orderDecimalQuantity is
>>>> set to N, then system should return error if we try to add to partial
>>>> quantity then system should return error instead of rounding it to 0,
>>>>> Actual Behavior: If partial quantity not allowed in in order process,
>>>> and user enter 1.5 quantity then it rounded it and add 2 quantity.
>>>>> Expected Behavior: if partial quantity not allowed then system should
>>>> return error instead of doing rounding if partial quantity passed during
>>>> add/update item.
>>>>
>>>>
>>>>
>>>> --
>>>> This message was sent by Atlassian JIRA
>>>> (v6.3.4#6332)
>>>>
Reply | Threaded
Open this post in threaded view
|

Re: [jira] [Comment Edited] (OFBIZ-5962) If orderDecimalQuantity set to N then system should return error if user add partial quantity in order

Robert Lasater-2
Thanks for clarifying Deepak. That is correct.

Robert

On Fri, Jan 16, 2015 at 1:17 PM, Jacques Le Roux <
[hidden email]> wrote:

> Thanks Deepak,
>
> Then, should we not open another Jira for that?
>
> Jacques
>
> Le 16/01/2015 13:48, Deepak Dixit a écrit :
>
>  I think Robert is talking about edit product screen. As we have
>> orderDecimalQuantity field in product entity but we don’t have option to
>> set it vie EditProduct screen.
>>
>> Thanks & Regards
>> —
>> Deepak Dixit
>>
>>  On Jan 16, 2015, at 6:00 PM, Jacques Le Roux <
>>> [hidden email]> wrote:
>>>
>>> Le 16/01/2015 07:44, Robert Lasater a écrit :
>>>
>>>> After a new product item is created,
>>>>
>>> What is a "new product item" ?
>>>
>>>> the option to change this setting is
>>>> no longer visible.
>>>>
>>> I guess you mean in the product store setting? I can't see any relation
>>> with a product
>>>
>>> Jacques
>>>
>>>> Is there a reason for hiding it? or is it a bug?
>>>>
>>>>
>>>>
>>>> On Thu, Jan 15, 2015 at 11:28 PM, Deepak Dixit (JIRA) <[hidden email]>
>>>> wrote:
>>>>
>>>>       [
>>>>> https://issues.apache.org/jira/browse/OFBIZ-5962?page=
>>>>> com.atlassian.jira.plugin.system.issuetabpanels:comment-
>>>>> tabpanel&focusedCommentId=14279866#comment-14279866
>>>>> ]
>>>>>
>>>>> Deepak Dixit edited comment on OFBIZ-5962 at 1/16/15 6:28 AM:
>>>>> --------------------------------------------------------------
>>>>>
>>>>> While fixing this issue found that orderDecimalQuantity check is
>>>>> missing
>>>>> while add item to order and update order item flow. I'll add these
>>>>> check as
>>>>> well for add item and update order flow.
>>>>>
>>>>>
>>>>> was (Author: deepak.dixit):
>>>>> While fixing this issue found that orderDecimalQuantity check is
>>>>> missing
>>>>> while add item to cart and update order item flow. I'll add these
>>>>> check as
>>>>> well for add item and update order flow.
>>>>>
>>>>>  If orderDecimalQuantity set to N then system should return error if
>>>>>> user
>>>>>>
>>>>> add partial quantity in order
>>>>> ------------------------------------------------------------
>>>>> ------------------------------------------
>>>>>
>>>>>>                  Key: OFBIZ-5962
>>>>>>                  URL: https://issues.apache.org/
>>>>>> jira/browse/OFBIZ-5962
>>>>>>              Project: OFBiz
>>>>>>           Issue Type: Bug
>>>>>>           Components: order
>>>>>>     Affects Versions: Release Branch 13.07, Trunk, 14.12.01
>>>>>>             Reporter: Deepak Dixit
>>>>>>             Assignee: Jacques Le Roux
>>>>>>
>>>>>> If productStore.orderDecimalQuantity and
>>>>>> product.orderDecimalQuantity is
>>>>>>
>>>>> set to N, then system should return error if we try to add to partial
>>>>> quantity then system should return error instead of rounding it to 0,
>>>>>
>>>>>> Actual Behavior: If partial quantity not allowed in in order process,
>>>>>>
>>>>> and user enter 1.5 quantity then it rounded it and add 2 quantity.
>>>>>
>>>>>> Expected Behavior: if partial quantity not allowed then system should
>>>>>>
>>>>> return error instead of doing rounding if partial quantity passed
>>>>> during
>>>>> add/update item.
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> This message was sent by Atlassian JIRA
>>>>> (v6.3.4#6332)
>>>>>
>>>>>
Reply | Threaded
Open this post in threaded view
|

Re: [jira] [Comment Edited] (OFBIZ-5962) If orderDecimalQuantity set to N then system should return error if user add partial quantity in order

Deepak Dixit-2
In reply to this post by Jacques Le Roux

> On Jan 17, 2015, at 1:47 AM, Jacques Le Roux <[hidden email]> wrote:
>
> Thanks Deepak,
>
> Then, should we not open another Jira for that?


Done, https://issues.apache.org/jira/browse/OFBIZ-6014

Thanks & Regards

Deepak Dixit
www.hotwaxsystems.com

>
> Jacques
>
> Le 16/01/2015 13:48, Deepak Dixit a écrit :
>> I think Robert is talking about edit product screen. As we have orderDecimalQuantity field in product entity but we don’t have option to set it vie EditProduct screen.
>>
>> Thanks & Regards
>> —
>> Deepak Dixit
>>
>>> On Jan 16, 2015, at 6:00 PM, Jacques Le Roux <[hidden email]> wrote:
>>>
>>> Le 16/01/2015 07:44, Robert Lasater a écrit :
>>>> After a new product item is created,
>>> What is a "new product item" ?
>>>> the option to change this setting is
>>>> no longer visible.
>>> I guess you mean in the product store setting? I can't see any relation with a product
>>>
>>> Jacques
>>>> Is there a reason for hiding it? or is it a bug?
>>>>
>>>>
>>>>
>>>> On Thu, Jan 15, 2015 at 11:28 PM, Deepak Dixit (JIRA) <[hidden email]>
>>>> wrote:
>>>>
>>>>>     [
>>>>> https://issues.apache.org/jira/browse/OFBIZ-5962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14279866#comment-14279866
>>>>> ]
>>>>>
>>>>> Deepak Dixit edited comment on OFBIZ-5962 at 1/16/15 6:28 AM:
>>>>> --------------------------------------------------------------
>>>>>
>>>>> While fixing this issue found that orderDecimalQuantity check is missing
>>>>> while add item to order and update order item flow. I'll add these check as
>>>>> well for add item and update order flow.
>>>>>
>>>>>
>>>>> was (Author: deepak.dixit):
>>>>> While fixing this issue found that orderDecimalQuantity check is missing
>>>>> while add item to cart and update order item flow. I'll add these check as
>>>>> well for add item and update order flow.
>>>>>
>>>>>> If orderDecimalQuantity set to N then system should return error if user
>>>>> add partial quantity in order
>>>>> ------------------------------------------------------------------------------------------------------
>>>>>>                 Key: OFBIZ-5962
>>>>>>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5962
>>>>>>             Project: OFBiz
>>>>>>          Issue Type: Bug
>>>>>>          Components: order
>>>>>>    Affects Versions: Release Branch 13.07, Trunk, 14.12.01
>>>>>>            Reporter: Deepak Dixit
>>>>>>            Assignee: Jacques Le Roux
>>>>>>
>>>>>> If productStore.orderDecimalQuantity and product.orderDecimalQuantity is
>>>>> set to N, then system should return error if we try to add to partial
>>>>> quantity then system should return error instead of rounding it to 0,
>>>>>> Actual Behavior: If partial quantity not allowed in in order process,
>>>>> and user enter 1.5 quantity then it rounded it and add 2 quantity.
>>>>>> Expected Behavior: if partial quantity not allowed then system should
>>>>> return error instead of doing rounding if partial quantity passed during
>>>>> add/update item.
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> This message was sent by Atlassian JIRA
>>>>> (v6.3.4#6332)
>>>>>


smime.p7s (6K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [jira] [Comment Edited] (OFBIZ-5962) If orderDecimalQuantity set to N then system should return error if user add partial quantity in order

Jacques Le Roux
Administrator
Thanks Deepak!

Jacques

Le 19/01/2015 06:15, Deepak Dixit a écrit :

>> On Jan 17, 2015, at 1:47 AM, Jacques Le Roux <[hidden email]> wrote:
>>
>> Thanks Deepak,
>>
>> Then, should we not open another Jira for that?
>
> Done, https://issues.apache.org/jira/browse/OFBIZ-6014
>
> Thanks & Regards
> —
> Deepak Dixit
> www.hotwaxsystems.com
>
>> Jacques
>>
>> Le 16/01/2015 13:48, Deepak Dixit a écrit :
>>> I think Robert is talking about edit product screen. As we have orderDecimalQuantity field in product entity but we don’t have option to set it vie EditProduct screen.
>>>
>>> Thanks & Regards
>>> —
>>> Deepak Dixit
>>>
>>>> On Jan 16, 2015, at 6:00 PM, Jacques Le Roux <[hidden email]> wrote:
>>>>
>>>> Le 16/01/2015 07:44, Robert Lasater a écrit :
>>>>> After a new product item is created,
>>>> What is a "new product item" ?
>>>>> the option to change this setting is
>>>>> no longer visible.
>>>> I guess you mean in the product store setting? I can't see any relation with a product
>>>>
>>>> Jacques
>>>>> Is there a reason for hiding it? or is it a bug?
>>>>>
>>>>>
>>>>>
>>>>> On Thu, Jan 15, 2015 at 11:28 PM, Deepak Dixit (JIRA) <[hidden email]>
>>>>> wrote:
>>>>>
>>>>>>      [
>>>>>> https://issues.apache.org/jira/browse/OFBIZ-5962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14279866#comment-14279866
>>>>>> ]
>>>>>>
>>>>>> Deepak Dixit edited comment on OFBIZ-5962 at 1/16/15 6:28 AM:
>>>>>> --------------------------------------------------------------
>>>>>>
>>>>>> While fixing this issue found that orderDecimalQuantity check is missing
>>>>>> while add item to order and update order item flow. I'll add these check as
>>>>>> well for add item and update order flow.
>>>>>>
>>>>>>
>>>>>> was (Author: deepak.dixit):
>>>>>> While fixing this issue found that orderDecimalQuantity check is missing
>>>>>> while add item to cart and update order item flow. I'll add these check as
>>>>>> well for add item and update order flow.
>>>>>>
>>>>>>> If orderDecimalQuantity set to N then system should return error if user
>>>>>> add partial quantity in order
>>>>>> ------------------------------------------------------------------------------------------------------
>>>>>>>                  Key: OFBIZ-5962
>>>>>>>                  URL: https://issues.apache.org/jira/browse/OFBIZ-5962
>>>>>>>              Project: OFBiz
>>>>>>>           Issue Type: Bug
>>>>>>>           Components: order
>>>>>>>     Affects Versions: Release Branch 13.07, Trunk, 14.12.01
>>>>>>>             Reporter: Deepak Dixit
>>>>>>>             Assignee: Jacques Le Roux
>>>>>>>
>>>>>>> If productStore.orderDecimalQuantity and product.orderDecimalQuantity is
>>>>>> set to N, then system should return error if we try to add to partial
>>>>>> quantity then system should return error instead of rounding it to 0,
>>>>>>> Actual Behavior: If partial quantity not allowed in in order process,
>>>>>> and user enter 1.5 quantity then it rounded it and add 2 quantity.
>>>>>>> Expected Behavior: if partial quantity not allowed then system should
>>>>>> return error instead of doing rounding if partial quantity passed during
>>>>>> add/update item.
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> This message was sent by Atlassian JIRA
>>>>>> (v6.3.4#6332)
>>>>>>