[jira] [Comment Edited] (OFBIZ-6217) fix warnings in trunk on java source code

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-6217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385200#comment-14385200 ]

Taher Alkhateeb edited comment on OFBIZ-6217 at 3/28/15 9:01 AM:
-----------------------------------------------------------------

I have created a new attachment called warnings_patch_2.patch and deleted the other patch to avoid confusion. This will bring down the number of warnings to 294. The patch includes the followings

- removal of deprecated code causing some warnings
- Introduction of generics to many collections
- conversion of many maps and lists to java API instead of the old fastmap and fastlist from javolution
- removal of redundant and unnecessary suppress tags
- addition of suppress tags to places where the issue is not solvable
- cleaning up iterator code to use generics
- refactoring some code where the generics are incorrectly applied

Please apply


was (Author: taher):
I have created a new attachment called warnings_patch_2.patch. This will bring down the number of warnings to 294. The patch includes the followings

- removal of deprecated code causing some warnings
- Introduction of generics to many collections
- conversion of many maps and lists to java API instead of the old fastmap and fastlist from javolution
- removal of redundant and unnecessary suppress tags
- addition of suppress tags to places where the issue is not solvable
- cleaning up iterator code to use generics
- refactoring some code where the generics are incorrectly applied

Please apply

> fix warnings in trunk on java source code
> -----------------------------------------
>
>                 Key: OFBIZ-6217
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6217
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Taher Alkhateeb
>            Priority: Minor
>              Labels: java, warning
>             Fix For: Upcoming Branch
>
>         Attachments: remove_unused_imports.patch, warnings_patch_2.patch
>
>
> Right now, we have 528 warnings on trunk out of which 238 are about raw types and 118 never used imports. So we can already eliminate most of the warning quite quickly.
> I will issue multiple patches to resolve most of these warnings. It might be a bit of a challenge to eliminate the raw types because the generics are not always deducable from the code especially when relying on external APIs

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)