[jira] [Comment Edited] (OFBIZ-6274) Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Comment Edited] (OFBIZ-6274) Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-6274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381235#comment-15381235 ]

Taher Alkhateeb edited comment on OFBIZ-6274 at 7/17/16 8:40 AM:
-----------------------------------------------------------------

Ahhhh now it makes sense. So the rename is adding more because org.apache.ofbiz is a subset of org.apache. Ok it clicks in place now.

But now I am not sure about your patch, by comparing your work with the older code isn't order important? Meaning should it not be:

{code:xml}
        <logger name="org.apache.ofbiz.base.converter.Converters" level="warn"/>
        <logger name="org.apache.ofbiz" level="info"/>
        <logger name="org.apache" level="warn"/>
{code}

Instead of

{code:xml}
    <Loggers>
        <logger name="org.apache" level="warn"/>
        <logger name="org.apache.ofbiz" level="info"/>
        <logger name="org.apache.ofbiz.base.converter.Converters" level="warn"/>
        ...
{code}


was (Author: taher):
Ahhhh now it makes sense. So the rename is adding more because org.apache.ofbiz is a subset of org.apache. Ok it clicks in place now.

But now I am not sure about your patch, by comparing your work with the older code isn't order important? Meaning should it not be:

{code: xml}
        <logger name="org.apache.ofbiz.base.converter.Converters" level="warn"/>
        <logger name="org.apache.ofbiz" level="info"/>
        <logger name="org.apache" level="warn"/>
{code}

Instead of

{code:xml}
    <Loggers>
        <logger name="org.apache" level="warn"/>
        <logger name="org.apache.ofbiz" level="info"/>
        <logger name="org.apache.ofbiz.base.converter.Converters" level="warn"/>
        ...
{code}

> Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-6274
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6274
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Pierre Smits
>            Assignee: Deepak Dixit
>         Attachments: FIX_LOGGING_OUPUT.patch, RENAME_OFBIZ_TO_APACHE.patch
>
>
> Currently (a lot of) our java and other artifacts sport the name/reference 'org.ofbiz'. This should be renamed to 'org.apache.ofbiz' to bring more consistency across the projects under the Apache umbrella.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)