[jira] [Comment Edited] (OFBIZ-6689) Have more flexibility in framework and applications regarding theming frameworks.

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Comment Edited] (OFBIZ-6689) Have more flexibility in framework and applications regarding theming frameworks.

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-6689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15093566#comment-15093566 ]

Pierre Smits edited comment on OFBIZ-6689 at 1/12/16 9:17 AM:
--------------------------------------------------------------

Modern theming frameworks have their own style definitions, and they often allow a combination of style elements in one html element, e.g.
{code}
<button type="button" class="btn btn-navbar">
{code}
in bootstrap vs:
{code}
<button class="button tiny radius success" type="submit">
{code}
in foundation. (these are just two unrelated examples)

Style definitions in widgets (e.g. menu's, menu-items, screenlets) are constructed in the widget component, through the Model*.java code and rendered via the various Renderer.java code before passed to the various freemarker libraries (the *Library.ftl files).

However, in current implementations (up to release branch 15.12) the style elements in the widgets cannot be set dynamically as the various code sections in the Model*.java define style elements as string and not as FlexibleStringExpander. This leads to an 'after the fact' correction in a theme, as has been shown in the bootstrap branch.


was (Author: pfm.smits):
Modern theming frameworks have their own style definitions, and they often allow a combination of style elements in one html element, e.g.
{code}
<button type="button" class="btn btn-navbar">
{code}
in bootstrap vs in foundation:
{code}
<button class="button tiny radius success" type="submit">
{code}
(these are just two unrelated examples)

Style definitions in widgets (e.g. menu's, menu-items, screenlets) are constructed in the widget component, through the Model*.java code and rendered via the various Renderer.java code before passed to the various freemarker libraries (the *Library.ftl files).

However, in current implementations (up to release branch 15.12) the style elements in the widgets cannot be set dynamically as the various code sections in the Model*.java define style elements as string and not as FlexibleStringExpander. This leads to an 'after the fact' correction in a theme, as has been shown in the bootstrap branch.

> Have more flexibility in framework and applications regarding theming frameworks.
> ---------------------------------------------------------------------------------
>
>                 Key: OFBIZ-6689
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6689
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL APPLICATIONS, framework, themes
>    Affects Versions: Trunk
>            Reporter: Pierre Smits
>            Assignee: Pierre Smits
>
> Modern theming frameworks like Bootstrap and Foundation define their own styling elements. In order to facilitate these frameworks (and others), the framework and applications need to be improved.
> This is an umbrella issue to track associated issues and sub tasks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)