[jira] [Comment Edited] (OFBIZ-6783) Refactor start.java

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Comment Edited] (OFBIZ-6783) Refactor start.java

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280184#comment-15280184 ]

Jacques Le Roux edited comment on OFBIZ-6783 at 5/11/16 2:24 PM:
-----------------------------------------------------------------

"Pos" and "Both" options work well as well.
It seems you can't use "both" option with debugging. But this was also not possible before... (I tried)
{code}
java -jar ofbiz.jar -b -g
{code}
Ha sorry just read "note: Only one command can execute at a time. Portoffset may be appended" so it's OK for
{code}
java -jar ofbiz.jar -b -g
{code}
which is wrong
:)



was (Author: jacques.le.roux):
"Pos" and "Both" options work well as well.
It seems you can't use "both" option with debugging. But this was also not possible before... (I tried)
{code}
java -jar ofbiz.jar -b -g
{code}


> Refactor start.java
> -------------------
>
>                 Key: OFBIZ-6783
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6783
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Upcoming Branch
>            Reporter: Taher Alkhateeb
>            Assignee: Taher Alkhateeb
>              Labels: framework, main, refactoring, start
>         Attachments: OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, StartCommandUtil.java
>
>
> Looking at the main method and design of Start.java looks ugly. The things I would like to fix so far are:
> - the file is too long
> - some variables are not even needed (loaderArgs?)
> - the level of abstraction is wrong
> - main throws an exception!
> - the arguments processing logic is terrible, need to move it to commons-cli
> It's just so messy and ugly to look at. So for me refactoring starts at Start! Given that this is an important file, I will provide a patch to be reviewed by the community before committing just to be on the safe side.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)