[jira] [Comment Edited] (OFBIZ-6783) Refactor the start component

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290791#comment-15290791 ]

Jacques Le Roux edited comment on OFBIZ-6783 at 5/19/16 10:57 AM:
------------------------------------------------------------------

Cool, could we not have also
{code}
--testlist file=runtime/test-list-build.xml
and
--testlist mode=ant or --testlist mode=text
{code}
I believe it's else still confusing, despite
{code}
Also a command must be invoked separately for each argument e.g.
java -jar ofbiz.jar --test component=somecomp --test case=somecase
{code}
TL;DR always wins against RTFM! ;)


was (Author: jacques.le.roux):
Cool, could we not have also
{code}
--testlist file=runtime/test-list-build.xml
and
--testlist mode=ant or --testlist mode=text
{code}
I believe it's else still confusing, despite
{code}
Also a command must be invoked separately for each argument e.g.
java -jar ofbiz.jar --test component=somecomp --test case=somecase
{code}
TL;DR always wins again RTFM! ;)

> Refactor the start component
> ----------------------------
>
>                 Key: OFBIZ-6783
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6783
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Upcoming Branch
>            Reporter: Taher Alkhateeb
>            Assignee: Taher Alkhateeb
>              Labels: framework, main, refactoring, start
>         Attachments: OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, StartCommandUtil.java
>
>
> Looking at the main method and design of Start.java and the start component overall looks ugly. The things I would like to fix so far are:
> - the files are too long
> - some variables are not even needed (loaderArgs?)
> - the level of abstraction is wrong
> - main throws an exception!
> - the arguments processing logic is terrible, need to move it to commons-cli
> It's just so messy and ugly to look at. So for me refactoring starts at Start! Given that this is an important component, I will provide a patch to be reviewed by the community before committing just to be on the safe side.

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)