[
https://issues.apache.org/jira/browse/OFBIZ-6986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15226088#comment-15226088 ]
Pranay Pandey edited comment on OFBIZ-6986 at 4/5/16 11:26 AM:
---------------------------------------------------------------
Hi Kulwant,
Thanks for making changes and uploading a new patch. I reviewed it and along with improvements suggested by Deepak, found a couple things that you should improve and upload new one. There are some formatting issues in the code blocks in methods formed.
One question that I have is, did you add test suite for HR intentionally or can be deleted for now, and when we are ready with some tests we add it that time. Please let me know and we'll go from there.
was (Author: pandeypranay):
Hi Kulwant,
Thanks for making changes and uploading a new patch. I reviewed it and found a couple things that you should improve and upload new one. There are some formatting issues in the code blocks in methods formed.
One question that I have is, did you add test suite for HR intentionally or can be deleted for now, and when we are ready with some tests we add it that time. Please let me know and we'll go from there.
> Simplify getChildHRCategoryTree
> -------------------------------
>
> Key: OFBIZ-6986
> URL:
https://issues.apache.org/jira/browse/OFBIZ-6986> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS, humanres
> Reporter: Kulwant
> Assignee: Pranay Pandey
> Attachments: OFBIZ-6986.patch
>
>
> breaking the single long method to multiple private functions with improved exception handling.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Locked
