[
https://issues.apache.org/jira/browse/OFBIZ-6986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15226087#comment-15226087 ]
Deepak Dixit edited comment on OFBIZ-6986 at 4/5/16 12:26 PM:
--------------------------------------------------------------
Hi Kulwant,
Thanks for your effort on this, here are some small suggestion:
- This is an git patch and we are using svn for repository, if you want to create patch from git then use git diff --no-prefix option to create patch.
- Do not use the javalution (Fast*) classes.
- Use UtilValidate method to check null values.
was (Author: deepak.dixit):
Hi Kulwant,
Thanks for your effort on this, here are some small suggestion:
- This is an git patch and we are using svn for repository, if you want to crate patch from git then use git diff --no-prefix option to crate patch.
- Do not use the javalution (Fast*) classes.
- Use UtilValidate method to check null values.
> Simplify getChildHRCategoryTree
> -------------------------------
>
> Key: OFBIZ-6986
> URL:
https://issues.apache.org/jira/browse/OFBIZ-6986> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS, humanres
> Reporter: Kulwant
> Assignee: Pranay Pandey
> Attachments: OFBIZ-6986.patch
>
>
> breaking the single long method to multiple private functions with improved exception handling.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Locked
