[jira] [Comment Edited] (OFBIZ-7511) Add proper form validation across the application

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343992#comment-15343992 ]

Divesh Dutta edited comment on OFBIZ-7511 at 6/22/16 12:16 PM:
---------------------------------------------------------------

[~jacques.le.roux]  this discussion has been concluded. There was confusion in actual problem area. Actually the problem area is:

When you use auto-field-service in form say for eg:

{code}
<form name="EditExampleFeature" type="single" target="updateExampleFeature" title="" default-map-name="exampleFeature">
        <auto-fields-service service-name="updateExampleFeature"/>
        <field name="submitButton" title="${uiLabelMap.CommonCreate}"><submit button-type="button"/></field>
 </form>
{code}

Then exampleFeatureId is mandatory field in this form because exampleFeatureId is mandatory attribute of service. Now if you create same form then where you want to use tool tip in exampleFeatureId ,

{code}
<form name="EditExampleFeature" type="single" target="updateExampleFeature" title="" default-map-name="exampleFeature">
        <auto-fields-service service-name="updateExampleFeature"/>
         <override field name="exampleFeatureId" title="${uiLabelMap.ExampleExampleFeatureId}" tooltip="${uiLabelMap.CommonNotModifRecreat}"><display/></field>
        <field name="submitButton" title="${uiLabelMap.CommonCreate}"><submit button-type="button"/></field>
 </form>
{code}

In this case, you have overridden the exampleFeatureId field, but during overriding required property is lost. And to solve this problem, Deepak is recommending that when you override the field , then by default required property should be inherited from auto-fields service, so that developer does not have to explicitly define required-field=true . And we agreed on this proposal of Deepak .

So we agreed on solution which maximally automates. Hope this helps to understand the problem area and solution concluded.


was (Author: diveshdut):
[~jacques.le.roux]  this discussion has been concluded. There was confusion in actual problem area. Actually the problem area is:

When you use auto-field-service in form say for eg:

{code}
<form name="EditExampleFeature" type="single" target="updateExampleFeature" title="" default-map-name="exampleFeature">
        <auto-fields-service service-name="updateExampleFeature"/>
        <field name="submitButton" title="${uiLabelMap.CommonCreate}"><submit button-type="button"/></field>
 </form>
{code}

Then exampleFeatureId is mandatory field in this form because exampleFeatureId is mandatory attribute of service. Now if you create same form then where you want to use tool tip in exampleFeatureId ,

{code}
<form name="EditExampleFeature" type="single" target="updateExampleFeature" title="" default-map-name="exampleFeature">
        <auto-fields-service service-name="updateExampleFeature"/>
        <field name="exampleFeatureId" title="${uiLabelMap.ExampleExampleFeatureId}" tooltip="${uiLabelMap.CommonNotModifRecreat}"><display/></field>
        <field name="submitButton" title="${uiLabelMap.CommonCreate}"><submit button-type="button"/></field>
 </form>
{code}

In this case, you have overridden the exampleFeatureId field, but during overriding required property is lost. And to solve this problem, Deepak is recommending that when you override the field , then by default required property should be inherited from auto-fields service, so that developer does not have to explicitly define required-field=true . And we agreed on this proposal of Deepak .

So we agreed on solution which maximally automates. Hope this helps to understand the problem area and solution concluded.

> Add proper form validation  across the application
> --------------------------------------------------
>
>                 Key: OFBIZ-7511
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7511
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL APPLICATIONS
>    Affects Versions: Trunk
>            Reporter: Deepak Dixit
>
> This is the place holder task for adding proper form validation across the application.

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)