[
https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361063#comment-15361063 ]
Jacques Le Roux edited comment on OFBIZ-7534 at 7/4/16 9:19 AM:
----------------------------------------------------------------
Hi Pierre,
I understand your concerns, reverting and removing and reaplying a such patch is not easy at 1st glance. But as long as you keep the .gradle part (so you don't need to manipulate the Gradle wrapper), and (for me at least) keep the .gradle and build svn:ignore properties, it's not so hard as well since, in Eclipse, you can also exclude keeped files when patching (like gradle-wrapper.properties). I know what I'm talking about, I just did it with the last patch, all works perfectly, even stuff like "gradlew svnInfoFooter"
I also don't think a branch is required. Apart few minor changes in Java code, it's mostly adds. Ant will still be in place with no Ant related changes (in builds, etc.)
Also there are some good changes, for instance see the NOTICE file. One thing is the removing of Eclipsthe .classpath and .project file. But it's a breeze to recreate them using "gradlew eclipse".
README.MD is better than README but we will maybe need to remove it later rather than now.
I have no ideas about "mvnrepository vs jcenter" (ie did not look at it). I guess Taher picked jcenter because it's in relation with Gradle.
was (Author: jacques.le.roux):
Hi Pierre,
I understand your concerns, reverting and removing and reaplying a such patch is not easy at 1st glance. But as long as you keep the .gradle part (so you don't need to manipulate the Gradle wrapper), and (for me at least) keep the .gradle and build svn:ignore properties, it's not so hard as well since, in Eclipse, you can also exclude keeped files when patching. I know what I'm talking about, I just did it with the last patch, all works perfectly, even stuff like "gradlew svnInfoFooter"
I also don't think a branch is required. Apart few minor changes in Java code, it's mostly adds. Ant will still be in place with no Ant related changes (in builds, etc.)
Also there are some good changes, for instance see the NOTICE file. One thing is the removing of Eclipsthe .classpath and .project file. But it's a breeze to recreate them using "gradlew eclipse".
README.MD is better than README but we will maybe need to remove it later rather than now.
I have no ideas about "mvnrepository vs jcenter" (ie did not look at it). I guess Taher picked jcenter because it's in relation with Gradle.
> Migrate OFBiz from Apache Ant to Gradle build system
> ----------------------------------------------------
>
> Key: OFBIZ-7534
> URL:
https://issues.apache.org/jira/browse/OFBIZ-7534> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: Upcoming Branch
> Reporter: Taher Alkhateeb
> Assignee: Taher Alkhateeb
> Labels: ant, build-tools, gradle
> Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, build.gradle, gradle-wrapper.jar
>
>
> This is a major refactoring task referring to the [email thread|
http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] in which the community voted for the switch after a proposal from the PMC
> The purpose of this JIRA is to achieve the following objectives
> - Fully implement a working compiling system in Gradle that passes all tests
> - Remove all ant and maven build scripts from the system
> - update the documentation of the system to reflect these changes
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Locked
