[jira] [Comment Edited] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Comment Edited] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369442#comment-15369442 ]

Taher Alkhateeb edited comment on OFBIZ-7534 at 7/10/16 6:45 AM:
-----------------------------------------------------------------

Ok Jacques, after further checking we slightly changed the old format of the footer. The old format used only the translated words _uiLabelMap.CommonBuiltOn_ and _uiLabelMap.CommonWith_. On the other hand, the new format contains the words Branch, Revision, Built On and Java Version.

Should we translate all four words in the CommonUiLabels.xml and then incorporate them?

old version:
{code}
" - Release-revision : ${releasePath}-r${info.entry.commit(revision)},  ${uiLabelMap.CommonBuiltOn} ${dateTime} ${uiLabelMap.CommonWith} Java ${java.version}
{code}

new version:
{code}
"Branch: ${info.entry.url.text()}" + System.lineSeparator()
"Revision: ${info.entry.commit.@revision}" + System.lineSeparator()
"Built on: ${timestamp}" + System.lineSeparator()
"Java Version: ${org.gradle.internal.jvm.Jvm.current()}"
{code}


was (Author: taher):
Ok Jacques, after further checking we slightly changed the old format of the footer. The old format used only the translated words _uiLabelMap.CommonBuiltOn_ and _uiLabelMap.CommonWith_. On the other hand, the new format contains the words Branch, Revision, Built On and Java Version.

Should we translate all four words in the CommonUiLabels.xml and then incorporate them?

old version:
" - Release-revision : ${releasePath}-r${info.entry.commit(revision)},  ${uiLabelMap.CommonBuiltOn} ${dateTime} ${uiLabelMap.CommonWith} Java ${java.version}

new version:
"Branch: ${info.entry.url.text()}" + System.lineSeparator()
"Revision: ${info.entry.commit.@revision}" + System.lineSeparator()
"Built on: ${timestamp}" + System.lineSeparator()
"Java Version: ${org.gradle.internal.jvm.Jvm.current()}"

> Migrate OFBiz from Apache Ant to Gradle build system
> ----------------------------------------------------
>
>                 Key: OFBIZ-7534
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7534
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: Upcoming Branch
>            Reporter: Taher Alkhateeb
>            Assignee: Taher Alkhateeb
>              Labels: ant, build-tools, gradle
>         Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, gradle-wrapper.jar
>
>
> This is a major refactoring task referring to the [email thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] in which the community voted for the switch after a proposal from the PMC
> The purpose of this JIRA is to achieve the following objectives
> - Fully implement a working compiling system in Gradle that passes all tests
> - Remove all ant and maven build scripts from the system
> - update the documentation of the system to reflect these changes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)