[
https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372707#comment-15372707 ]
Rishi Solanki edited comment on OFBIZ-7622 at 7/12/16 11:32 AM:
----------------------------------------------------------------
Adding user login at each entity and logging an additional filed for all and maintaining the relationship by default with UserLogin entity. In first look it looks like good idea, but it will come with many challenges.
IMO, we should check the business needs of each entity and decide weather to do this for that entity or not. For example, for all the type entities do we really need change by userLogin?. Type entities are in hundreds, why should they maintain the relationship. Also all the intersection entities like PartyContactMech, ProductCategoryMember, ProductAssoc, ProductCategoryRollup and many more, why these entities requires this extra field and relationship?
Also for each relationship databases manage indexes, which will increase the db size for the same data.
I would say many entities may require user login field, but all requires some discussion, review, and closer look before proceeding. Maintaining this like DATE fields is not look a good idea to me, instead adding this field wherever required after discussion looks better to me. In that process (reviewing and adding user login field to other entities) if we found all the entities should maintain user login then we can proceed and think of adding user login for all.
was (Author: rishisolankii):
Adding user login at each entity and logging an additional filed for all and maintaining the relationship by default with UserLogin entity. In first look it looks like good idea, but it will come with many challenges.
IMO, we should check the business needs of each entity and decide weather to do this for that entity or not. For example, for all the type entities do we really need change by userLogin?. Type entities are in hundreds, why should they maintain the relationship. Also all the intersection entities like PartyContactMech, ProductCategoryMember, ProductAssoc, ProductCategoryRollup and many more, why these entities requires this extra field and relationship?
Also for each relationship databases manage indexes, which will increase the db size with for the same data.
I would say many entities may require user login field, but all requires some discussion, review, and closer look before proceeding. Maintaining this like DATE fields is not look a good idea to me, instead adding this field wherever required after discussion looks better to me. In that process (reviewing and adding user login field to other entities) if we found all the entities should maintain user login then we can proceed and think of adding user login for all.
> Add "changeByUserLoginId" field for CustRequestStatus
> -----------------------------------------------------
>
> Key: OFBIZ-7622
> URL:
https://issues.apache.org/jira/browse/OFBIZ-7622> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
> Affects Versions: Trunk
> Reporter: Nameet Jain
> Assignee: Julien NICOLAS
> Attachments: OFBIZ-7622.patch, OFBIZ-7622.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Locked
