[jira] [Comment Edited] (OFBIZ-7771) Rename loadDefault to something less ambiguous

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Comment Edited] (OFBIZ-7771) Rename loadDefault to something less ambiguous

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-7771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15371474#comment-15371474 ]

Pierre Smits edited comment on OFBIZ-7771 at 7/11/16 7:37 PM:
--------------------------------------------------------------

My apologies to all who feel that they get vexed by the issues I am experiencing with this switch.

If the 'loadDefault' is not intended to load all data, but is just intended to load the data sets that were previously designated as the load-demo task with the ant solution, and thus for demo-purposes (which I agree can also be used by developers and testers for their specific purposes and processes), then an equally good suggestion would be rename it to:

*loadDemoData* or *loadDemoDataSets*

[~jacques.le.roux]: thank you for taking upon you the task to also provide better suggestions. Thank you.


was (Author: pfm.smits):
My apologies to all who feel that they get vexed by the issues I am experiencing with this switch.

If the 'loadDefault' is not intended to load all data, but is just intended to load the data sets that were previously designated as the load-demo task with the ant solution, and thus for demo-purposes (which I agree can also be used by developers and tested for their specific purposes and process), then an equally good suggestion would be rename it to:

*loadDemoData* or *loadDemoDataSets*

[~jacques.le.roux]: thank you for taking upon you the task to also provide better suggestions. Thank you.

> Rename loadDefault to something less ambiguous
> ----------------------------------------------
>
>                 Key: OFBIZ-7771
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7771
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Pierre Smits
>            Priority: Trivial
>
> The gradle task loadDefault is ambiguous, as it means different things to different uses. This could lead to a situations where it is used in a wrong manner, resulting in data being overwritten.
> Having a more meaningful name lessens the risk of such situations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)