[
https://issues.apache.org/jira/browse/OFBIZ-7783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15432332#comment-15432332 ]
Jacques Le Roux edited comment on OFBIZ-7783 at 8/30/16 9:16 PM:
-----------------------------------------------------------------
Thanks Taher,
Before we discuss this more on the dev ML, just some points:
# archiving the Gradle cache is not enough, because you can have not only OFBiz related libs in it, for instance on a dev machine
* which use Eclipse: Eclipse libs
* if Gradle is also used for other projects, unrelated OFBiz libs
* etc.
That's why I have decided to have a task like that (initially for OWASP)
# Using plugins is certainly more appealing, but
* I don't feel an issue to use jQuery plugins because it's just UI and if the plugin is not longer maintained we can still find solutions. Relying on external plugins for our build process is another matter.
* I must say I just had a glance to the gradle-repositories-plugin but I wonder how it works, because on GitHub you get a zip with jar inside...
Now I have identified another reasons we migh need to extract and copy the external libs we use: if we decide to deliver binary releases. It's not mandatory but most TLPs do that. It can of course be done by a 3rd party and then it's another issue... This is in a relation with
http://markmail.org/message/emnu6s5wu2yuyithwas (Author: jacques.le.roux):
Thanks Taher,
Before we discuss this more on the dev ML, just some points:
# archiving the Gradle cache is not enough, because you can have not OFBiz related libs in it, for instance on a dev machine
* which use Eclipse: Eclipse libs
* if Gradle is also used for other projects, unrelated OFBiz libs
* etc.
That's why I have decided to have a task like that (initially for OWASP)
# Using plugins is certainly more appealing, but
* I don't feel an issue to use jQuery plugins because it's just UI and if the plugin is not longer maintained we can still find solutions. Relying on external plugins for our build process is another matter.
* I must say I just had a glance to the gradle-repositories-plugin but I wonder how it works, because on GitHub you get a zip with jar inside...
Now I have identified another reasons we migh need to extract and copy the external libs we use: if we decide to deliver binary releases. It's not mandatory but most TLPs do that. It can of course be done by a 3rd party and then it's another issue... This is in a relation with
http://markmail.org/message/emnu6s5wu2yuyith> External library files are not in the OFBiz folder structure.
> -------------------------------------------------------------
>
> Key: OFBIZ-7783
> URL:
https://issues.apache.org/jira/browse/OFBIZ-7783> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
> Reporter: Pierre Smits
> Priority: Minor
> Fix For: Upcoming Branch
>
>
> With the implementation of the external library download feature of gradle/gradlew, the external libraries (jar files) are not in the folder structure any more.
> They should reside there, like before.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Locked
