[jira] [Comment Edited] (OFBIZ-9571) [DEPRECATION] Replace BigDecimal.ROUND_* by RoundingMode.*

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-9571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125368#comment-16125368 ]

Jacques Le Roux edited comment on OFBIZ-9571 at 8/14/17 9:37 AM:
-----------------------------------------------------------------

In a 1st step at revision: 1804953, I did an easy global replacement. But it also needs to import the RoundingMode class. It was 26 files so I decided to rather clean all the imports in all files with the help of Eclipse.

In a 2nd step, I will need to closely look at 2 special classes: UtilNumber and Calculate.



was (Author: jacques.le.roux):
In a 1st step at revision: 1804953, I did an easy global replacement. But it also needs to import the RoundingMode class. It was 26 files so I decided to rather clean all the imports in all files with the help of Eclipse.

In a 2nd step, I will need to closely look at 2 special class: UtilNumber and Calculate.

> [DEPRECATION] Replace BigDecimal.ROUND_* by RoundingMode.*
> ----------------------------------------------------------
>
>                 Key: OFBIZ-9571
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9571
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: Upcoming Release
>
>
> 3 years ago I wrote about that in dev ML: https://s.apache.org/EVxA
> bq.  I just read at http://docs.oracle.com/javase/7/docs/api/java/math/BigDecimal.html : <<Using the integer fields in this class (such as [ROUND_HALF_UP|http://docs.oracle.com/javase/7/docs/api/java/math/BigDecimal.html#ROUND_HALF_UP]) to represent rounding mode is largely obsolete; the enumeration values of the RoundingMode enum, (such as [RoundingMode.HALF_UP|http://docs.oracle.com/javase/7/docs/api/java/math/RoundingMode.html#HALF_UP]) should be used instead.
> It's time for action...

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)