[
https://issues.apache.org/jira/browse/OFBIZ-9634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16141619#comment-16141619 ]
Dennis Balkir edited comment on OFBIZ-9634 at 8/25/17 1:35 PM:
---------------------------------------------------------------
- Diamond Operators fixed
- Line 70: changes not necessary
- Line 107: deleted {{= new LinkedHashMap<>()}} because it is not necessary at this point
was (Author: dennis balkir):
- Diamond Operators fixed
- Line 70: changes not necessary
- Line 107: deleted {{ = new LinkedHashMap<>()}} because it is not necessary at this point
> [FB] Package org.apache.ofbiz.common.uom
> ----------------------------------------
>
> Key: OFBIZ-9634
> URL:
https://issues.apache.org/jira/browse/OFBIZ-9634> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
> Affects Versions: Trunk
> Reporter: Dennis Balkir
> Priority: Minor
> Attachments: OFBIZ-9634_org.apache.ofbiz.common.uom_bugfixes.patch
>
>
> - UomWorker.java:70, PZLA_PREFER_ZERO_LENGTH_ARRAYS
> PZLA: Should org.apache.ofbiz.common.uom.UomWorker.uomTimeToCalTime(String) return a zero length array rather than null?
> It is often a better design to return a length zero array rather than a null reference to indicate that there are no results (i.e., an empty list of results). This way, no explicit check for null is needed by clients of the method.
> On the other hand, using null to indicate "there is no answer to this question" is probably appropriate. For example, File.listFiles() returns an empty list if given a directory containing no files, and returns null if the file is not a directory.
> - UomWorker.java:107, DLS_DEAD_LOCAL_STORE
> DLS: Dead store to svcOutMap in org.apache.ofbiz.common.uom.UomWorker.convertUom(BigDecimal, String, String, LocalDispatcher)
> This instruction assigns a value to a local variable, but the value is not read or used in any subsequent instruction. Often, this indicates an error, because the value computed is never used.
> Note that Sun's javac compiler often generates dead stores for final local variables. Because FindBugs is a bytecode-based tool, there is no easy way to eliminate these false positives.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
Locked
