[
https://issues.apache.org/jira/browse/OFBIZ-9841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16203713#comment-16203713 ]
Jacques Le Roux edited comment on OFBIZ-9841 at 10/13/17 3:38 PM:
------------------------------------------------------------------
Thanks Yash,
Your patch is in trunk at revision: 1812144
I have just formatted both updateByCondition methods
BTW, why do you consider this a critical bug? Even with the useless but also harmless closings of the passed SQLProcessor in updateByCondition and select methods I see no reasons to consider this a bug, even less a critical one. If you agree please change and close. Else explain and we will need to backport...
was (Author: jacques.le.roux):
Thanks Yash,
Your patch is in trunk at revision: 1812144
I have just formatted both updateByCondition methods
BTW, why do you consider this a critical bug. Even with the useless but also harmless closings of the passed SQLProcessor in updateByCondition and select methods I see no reasons to consider this a bug, even less a critical one. If you agree please change and close. Else explain and we will need to backport...
> Implement AutoCloseable interface in SQLProcessor Class
> -------------------------------------------------------
>
> Key: OFBIZ-9841
> URL:
https://issues.apache.org/jira/browse/OFBIZ-9841> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: Trunk
> Reporter: Pradhan Yash Sharma
> Assignee: Pradhan Yash Sharma
> Priority: Critical
> Fix For: Trunk
>
> Attachments: OFBIZ-9841.patch, OFBIZ-9841.patch
>
>
> Implement SQLProcessor class with the AutoCloseable interface.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
Locked
