[
https://issues.apache.org/jira/browse/OFBIZ-9905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16741185#comment-16741185 ]
Pierre Smits edited comment on OFBIZ-9905 at 1/12/19 9:26 AM:
--------------------------------------------------------------
Hi [~sourabh.jain],
With your proposed patch your transcending the subject of the ticket (title + description). You're not only addressing the 'create' actions regarding agreements (in accounting), but everywhere a 'create new' action appears (in multiple other components). I suggest changing the particulars of the ticket so that it covers the actual change. Our adopters (those still using older releases) will benefit from a clearer title and description when assessing tickets (release notes) for application in their implementation.
With the patch you're suggesting to invalidate numerous component specific create labels. However, those don't get removed from the various UiLabel.xml files.
was (Author: pfm.smits):
Hi [~sourabh.jain],
With your proposed patch your transcending the subject of the ticket (title + description). You're not only addressing the 'create' actions regarding agreements (in accounting), but everywhere a 'create new' action appears (in multiple other components). I suggest changing the particulars of the ticket so that it covers the actual change. Our adopters (those still using older releases) will benefit from a clearer title and description when assessing tickets (release notes) for application in their implementation.
With the path you're suggesting to invalidate numerous component specific create labels. However, those don't get removed from the various UiLabel.xml files.
> Issue with Agreement under Accounting
> -------------------------------------
>
> Key: OFBIZ-9905
> URL:
https://issues.apache.org/jira/browse/OFBIZ-9905> Project: OFBiz
> Issue Type: Bug
> Environment:
https://demo-trunk.ofbiz.apache.org/accounting/control/EditAgreement> Reporter: Aayush jain
> Assignee: sourabh jain
> Priority: Major
> Attachments: OFBIZ-9905.patch, OFBIZ-9905.patch, UI_label .png
>
>
> Following issues found:
> 1. Create Agreement opens an edit agreement window
> 2. Able to Create Agreement without any detail (empty Agreement)
> Steps:
> 1. Open URL
https://demo-trunk.ofbiz.apache.org/accounting/control/FindAgreement> 2. Navigate to Agreement section
> 3. Click on create Agreement
> 4. Click submit button
> Actual: Agreement id is generated for empty agreement and when create window opens, it's redirection is wrong to edit window
> Expected: Proper redirection should be there (create agreement) and if an agreement is created without any details its of no use.
> Note: Same Issue exist with following screens:
> 1. Billing Account
> 2. Tax Authority
> 3. Agreement
> 4. Fixed Asset
> 5. Vendor
> 6. WebSite
> 7. Blog
> 8. Employment
> 9. Employee Position
> 10.Performance Review
> 11.Job Requisition
> 12. Party Resume
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Locked
