[jira] [Comment Edited] (OFBIZ-9978) Upgrade Jquery 1.11.0 to JQuery 3.2.1

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-9978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16275406#comment-16275406 ]

Aditya Sharma edited comment on OFBIZ-9978 at 12/2/17 4:28 AM:
---------------------------------------------------------------

Updated patch includes following changes
jQuery UI upgraded to  1.12.1
Included CSS files to theme properties and screens.
Manually added datepicker-en.js and datepicker-it-CH.js a new candidate added it to jsLanguageFilesMapping
Updated defaultDateTime path of dateTime picker it was having path of timepicker files.
I18n files for datepicker renamed from jquery.ui.datepicker- to datepicker- as comes with the JQuery ui package so that we don’t have to rename files manually everytime we upgrade.
https://github.com/jquery/jquery-ui/tree/master/ui/i18n 
Can’t get jquery-ui-i18n.js file though it was not used either.

I have not updated jQuery.cookie-1.4.0.js as it is related to jstree and we will update & move it when we will update jstree.

Though I feel JQuery ui should also be in plugins folder with other JQuery plugins.

Verify:
https://localhost:8443/example/control/main
Click on New Example, dialog works with validation

https://localhost:8443/example/control/EditExampleFeature
Validations working

https://localhost:8443/example/control/FormWidgetExamples
Date Time picker working fine
Drop down fields working fine
Autocomplete Dropdown ui improved and working fine
Multiple drop-downs working fine
Lookup Fields are working fine
Fields groups expand all and collapse all are working fine
Mask field working fine

https://localhost:8443/example/control/authview/findExampleAjax
Name field in place editable and working fine

No issues with
https://localhost:8443/example/control/ExampleGeoLocationPointSet1
https://localhost:8443/example/control/ExampleBarChart

Jstree working fine
https://localhost:8443/catalog/control/main
https://localhost:8443/humanres/control/main

Elrte working fine
https://localhost:8443/content/control/findForumMessages?forumGroupId=WebStoreFORUM&forumId=ASK


Jeditable 1.7.2 upgraded to 1.7.3
https://github.com/tuupola/jquery_jeditable
Verify:
https://localhost:8443/example/control/authview/findExampleAjax (Name field is editable)
Though I feel we will soon replace it with plugins like TinyMCE https://github.com/tinymce/tinymce as no community support after 2013.


was (Author: aditya.sharma):
Updated patch includes following changes
jQuery UI upgraded to  1.12.1
Included CSS files to theme properties and screens.
Manually added datepicker-en.js and datepicker-it-CH.js a new candidate added it to jsLanguageFilesMapping
Updated defaultDateTime path of dateTime picker it was having path of timepicker files.
I18n files for datepicker renamed from jquery.ui.datepicker-*.js to datepicker-* as comes with the JQuery ui package so that we don’t have to rename files manually everytime we upgrade.
https://github.com/jquery/jquery-ui/tree/master/ui/i18n 
Can’t get jquery-ui-i18n.js file though it was not used either.

I have not updated jQuery.cookie-1.4.0.js as it is related to jstree and we will update & move it when we will update jstree.

Though I feel JQuery ui should also be in plugins folder with other JQuery plugins.

Verify:
https://localhost:8443/example/control/main
Click on New Example, dialog works with validation

https://localhost:8443/example/control/EditExampleFeature
Validations working

https://localhost:8443/example/control/FormWidgetExamples
Date Time picker working fine
Drop down fields working fine
Autocomplete Dropdown ui improved and working fine
Multiple drop-downs working fine
Lookup Fields are working fine
Fields groups expand all and collapse all are working fine
Mask field working fine

https://localhost:8443/example/control/authview/findExampleAjax
Name field in place editable and working fine

No issues with
https://localhost:8443/example/control/ExampleGeoLocationPointSet1
https://localhost:8443/example/control/ExampleBarChart

Jstree working fine
https://localhost:8443/catalog/control/main
https://localhost:8443/humanres/control/main

Elrte working fine
https://localhost:8443/content/control/findForumMessages?forumGroupId=WebStoreFORUM&forumId=ASK


Jeditable 1.7.2 upgraded to 1.7.3
https://github.com/tuupola/jquery_jeditable
Verify:
https://localhost:8443/example/control/authview/findExampleAjax (Name field is editable)
Though I feel we will soon replace it with plugins like TinyMCE https://github.com/tinymce/tinymce as no community support after 2013.

> Upgrade Jquery 1.11.0 to JQuery 3.2.1
> -------------------------------------
>
>                 Key: OFBIZ-9978
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9978
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Aditya Sharma
>            Assignee: Jacques Le Roux
>         Attachments: Image 001.png, Image 002.png, Image 003.png, OFBIZ-9978.patch, OFBIZ-9978.patch, OFBIZ-9978.patch, OFBIZ-9978.patch, OFBIZ-9978.patch, OFBIZ-9978_plugins.patch, OFBIZ-9978_plugins.patch, OFBIZ-9978_plugins.patch, OFBIZ-9978_plugins.patch, OFBIZ-9978_plugins.patch, Screenshot-2017-11-26 OFBiz Example .png
>
>
> Migration Steps:
> 1. Upgrade JQuery 1.11.0 to 3.2.1
>   * Remove JQuery 1.x & JQuery migrate 1.x
>   * Add JQuery 3.2.1 & JQuery migrate 3.0.0
>   * Rectify any broken code and plugin
> 2. Upgrade all the JQuery plugins to latest
> 3. Remove JQuery migrate 3.0.0 & rectify any broken code

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)