[jira] [Comment Edited] (OFBIZ-9985) Convert BudgetServices.xml mini lang to groovy

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Comment Edited] (OFBIZ-9985) Convert BudgetServices.xml mini lang to groovy

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-9985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16259027#comment-16259027 ]

Jacques Le Roux edited comment on OFBIZ-9985 at 11/20/17 10:01 AM:
-------------------------------------------------------------------

My answer was more in general. I really reviewed this time. I found that Nicolas decided to not migrate to entity-auto in OFBIZ-5900. I guess it's because of the call to updateBudgetStatus in createBudget. Now the question is why should we create a BG_CREATED budget status to when creating a budget?

Hi [~hansbak] could you enlighten us about that? In my opinion it should be decoupled, but I'm maybe missing something?

Note: about OFBIZ-5900, since then BudgetRole has been converted to entity-auto


was (Author: jacques.le.roux):
My answer was more in general. I really reviewed this time. I found that Nicolas decided to not migrate to entity-auto in OFBIZ-5900. I guess it's because of the call to updateBudgetStatus in createBudget. Now the question is why should we create a BG_CREATED budget status to when creating a budget?

Hi [~hansbak] could you enlighten us about that?

Note: about OFBIZ-5900, since then BudgetRole has been converted to entity-auto

> Convert BudgetServices.xml mini lang to groovy
> ----------------------------------------------
>
>                 Key: OFBIZ-9985
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9985
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: Trunk
>            Reporter: Leila Mekika
>            Priority: Minor
>         Attachments: OFBIZ-9985.patch
>
>
> This is an attempt to migrate BudgetServices.xml to groovy file version.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)