[jira] [Commented] (OFBIZ-10001) Convert CategoryContentServices.xml mini lang to groovy

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-10001) Convert CategoryContentServices.xml mini lang to groovy

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-10001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544497#comment-16544497 ]

Deepak Dixit commented on OFBIZ-10001:
--------------------------------------

Thanks [~Dennis Balkir] for patch, It looks good to me
Some suggestions
As we are doing refactoring, so we can convert service to entity-auto where applicable,
like we can use entity-auto for following services
  - createCategoryContent
  - updateCategoryContent

We can use group service for following services
- createSimpleTextContentForCategory
- updateSimpleTextContentForCategory

We can use uploadFileInterface for updateDownloadContentForCategory

Please let me know if it looks good to you

> Convert CategoryContentServices.xml mini lang to groovy
> -------------------------------------------------------
>
>                 Key: OFBIZ-10001
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10001
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: Trunk
>            Reporter: Dennis Balkir
>            Priority: Minor
>         Attachments: OFBIZ-10001_org.apache.ofbiz.product.category.CategoryContentServices_convert.patch
>
>
> Migration of the CategoryContentServices.xml to Groovy



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)