[
https://issues.apache.org/jira/browse/OFBIZ-10001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17040069#comment-17040069 ]
Pierre Smits commented on OFBIZ-10001:
--------------------------------------
Some vetting feedback:
{code:java}
+1 overall
____ _
/ ___| _ _ ___ ___ ___ ___ ___| |
\___ \| | | |/ __/ __/ _ \/ __/ __| |
___) | |_| | (_| (_| __/\__ \__ \_|
|____/ \__,_|\___\___\___||___/___(_)
| Vote | Subsystem | Runtime | Comment
============================================================================
| 0 | reexec | 0m 47s | Docker mode activated.
+---------------------------------------------------------------------------
| | | | Prechecks
+---------------------------------------------------------------------------
| +1 | dupname | 0m 0s | No case conflicting files found.
| +1 | @author | 0m 1s | The patch does not contain any @author
| | | | tags.
+---------------------------------------------------------------------------
| | | | trunk Compile Tests
+---------------------------------------------------------------------------
+---------------------------------------------------------------------------
| | | | Patch Compile Tests
+---------------------------------------------------------------------------
| +1 | whitespace | 0m 0s | The patch has no whitespace issues.
| +1 | xml | 0m 3s | The patch has no ill-formed XML file.
+---------------------------------------------------------------------------
| | | | Other Tests
+---------------------------------------------------------------------------
| 0 | asflicense | 1m 2s | ASF License check generated no output?
| | | 27m 43s |
|| Subsystem || Report/Notes ||
============================================================================
| Docker | Client=18.09.2 Server=18.09.2 base: /Users/nl04748/dev/test/yetus/ofbiz/OFBIZ-10001/Dockerfile |
| JIRA Issue | OFBIZ-10001 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12911530/OFBIZ-10001_org.apache.ofbiz.product.category.CategoryContentServices_convert.patch |
{code}
> Convert CategoryContentServices.xml mini lang to groovy
> -------------------------------------------------------
>
> Key: OFBIZ-10001
> URL:
https://issues.apache.org/jira/browse/OFBIZ-10001> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: Trunk
> Reporter: Dennis Balkir
> Assignee: Michael Brohl
> Priority: Minor
> Labels: refactoring
> Attachments: OFBIZ-10001_org.apache.ofbiz.product.category.CategoryContentServices_convert.patch
>
>
> Migration of the CategoryContentServices.xml to Groovy
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Locked
