[jira] [Commented] (OFBIZ-10044) Refactor and cleanup DhlServices.java

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-10044) Refactor and cleanup DhlServices.java

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17055678#comment-17055678 ]

Pierre Smits commented on OFBIZ-10044:
--------------------------------------


Benjamin,

This ticket is about functionalities regarding the DHL TPL integration.  So yes, my comment 3 years ago is about disentangling such from the warehousing application in the ‘APPLICATIONS’ stack of the base repository and having these functionalities in a separate component in the plugins repo.

But yes, this can an should be applied to the functionality sets (screens, services, etc.) of any of the 3rd Party Solution Integrations (whether 3rd Party Fintecch, or 3rd Party Logistics, or others). This would benefit the project and its (potential) adopters, because of offering more choice. Any other (semi) open source E-commerce and ERP solution offers such choice in a better way than the OFBiz project. This project only offers the swallow-all option.

If the project were to decide to move all these 3rd Party Integrations from the base repository to the plugins repository, it would not offer this kind of choice but only migrate the underlying issue.

Back in 2016 this was already brought to the community and master tickets were established (OFBIZ-7935 for TPL integrations and OFBIZ-7415 for TPF integrations),


> Refactor and cleanup DhlServices.java
> -------------------------------------
>
>                 Key: OFBIZ-10044
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10044
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: Trunk
>            Reporter: Michael Brohl
>            Assignee: Michael Brohl
>            Priority: Minor
>
> The DhlServices class contains many TODO comments and needs refactoring/cleanup.
> Hard coded defaults should be moved out to properties or database entries.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)