[
https://issues.apache.org/jira/browse/OFBIZ-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293904#comment-16293904 ]
Jacques Le Roux commented on OFBIZ-10047:
-----------------------------------------
Thanks James,
This works now and I see you have fixed all the points I mentionned. There is just something we need to change
{code}
+ if ("This request has already been authenticated".equals(e.getMessage())){
+ return true;
+ } else {
+ Debug.logError(e, module);
+ return false;
+ }
{code}
We should not rely on an English String. Better to rely on coyoteRequest.alreadyAuthenticated in LocalStrings.properties as in
https://svn.apache.org/repos/asf/tomcat/tc8.5.x/trunk/java/org/apache/catalina/connector/LocalStrings.propertiesSee this one for instance
https://fossies.org/linux/apache-tomcat/java/org/apache/catalina/connector/LocalStrings_es.properties> Tomcat SSO
> ----------
>
> Key: OFBIZ-10047
> URL:
https://issues.apache.org/jira/browse/OFBIZ-10047> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: Trunk
> Reporter: James Yong
> Assignee: James Yong
> Priority: Minor
> Attachments: OFBIZ-10047.patch, OFBIZ-10047.patch, OFBIZ-10047.patch
>
>
> Proposing Tomcat SSO to be used in OFBiz to improve on Single-Sign-On.
> This aim to fix the issues mentioned in OFBIZ-6963, OFBIZ-6994.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
Locked
