[
https://issues.apache.org/jira/browse/OFBIZ-10052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16289179#comment-16289179 ]
Jacques Le Roux commented on OFBIZ-10052:
-----------------------------------------
With pending changes, there are 822 case for Debug.verboseOn(). I see that there are also use of
* Debug.infoOn() 281 cases for 1689 Debug.logInfo() in Java and Groovy files
* Debug.timingOn() 12 cases
* Debug.errorOn() 2 cases
* Debug.warningOn() 9 cases
* Debug.importantOn() 2 cases
* none for fatal and always
It's an easy fix to always check if one level is on before printing debugging info. Do we think it's a good things to do? IMO it can't hurt and can help performance on stable production instances.
Though sincerely, as it's OOTB, personally I'd not prevent other levels than verbose in a production system, even a stable one, or a really stable one for years which really needs better performance ;)
As usual, "Premature optimisation is the root of all evil"!
> Always check if debug verbose is on when using Debug.logVerbose()
> -----------------------------------------------------------------
>
> Key: OFBIZ-10052
> URL:
https://issues.apache.org/jira/browse/OFBIZ-10052> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: Trunk
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: Upcoming Release
>
>
> [We recently discussed on this point|
http://markmail.org/message/mplvusuqn7oshl4v] and we agreed about better doing a check when using Debug.logVerbose().
> I checked there are 300+ cases like that. Since it's an easy S/R I'll directly soon commit a fix after a fast review.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
Locked
