[jira] [Commented] (OFBIZ-10052) Always check if debug verbose is on when using Debug.logVerbose()

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-10052) Always check if debug verbose is on when using Debug.logVerbose()

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-10052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293912#comment-16293912 ]

Jacques Le Roux commented on OFBIZ-10052:
-----------------------------------------

Thanks Michael,

They are those which were not using brackets, like
{code}
-                if (Debug.verboseOn())
-                    if (Debug.verboseOn()) Debug.logVerbose("Part 2 Text :\n\n" + part2Text, module);
{code}
Fortunately they are not too hard to replace and this is done at revision: 1818445.

They can't be multi-lines cases. I mean if (Debug.verboseOn())  on more than 2 lines.


> Always check if debug verbose is on when using Debug.logVerbose()
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-10052
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10052
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Upcoming Release
>
>
> [We recently discussed on this point|http://markmail.org/message/mplvusuqn7oshl4v] and we agreed about better doing a check when using Debug.logVerbose().
> I checked there are 300+ cases like that. Since it's an easy S/R I'll directly soon commit a fix  after a fast review.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)