[jira] [Commented] (OFBIZ-10113) Replace Asm select plugin with Select2.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-10113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327382#comment-16327382 ]

Jacques Le Roux commented on OFBIZ-10113:
-----------------------------------------

I found this error in trunk demo error.log
{code}
2018-01-16 15:45:48,585 |jsse-nio-8443-exec-3 |UtilXml                       |E| XmlFileLoader: File XML Properties file process fatal error. Line: 1670. Error message: The content of elements must consist of well-formed character data or markup.
2018-01-16 15:45:48,617 |jsse-nio-8443-exec-3 |UtilXml                       |E| XmlFileLoader: File XML Properties file process fatal error. Line: 1670. Error message: The content of elements must consist of well-formed character data or markup.
2018-01-16 15:45:48,648 |jsse-nio-8443-exec-3 |UtilXml                       |E| XmlFileLoader: File XML Properties file process fatal error. Line: 1670. Error message: The content of elements must consist of well-formed character data or markup.
2018-01-16 15:45:48,649 |jsse-nio-8443-exec-3 |AbstractModelAction           |E| Error adding resource bundle [HumanResUiLabels]: java.lang.IllegalArgumentException: Could not find resource bundle [HumanResUiLabels] in the locale [cs]
java.lang.IllegalArgumentException: Could not find resource bundle [HumanResUiLabels] in the locale [cs]
        at org.apache.ofbiz.base.util.UtilProperties.getResourceBundle(UtilProperties.java:720) ~[ofbiz.jar:?]
        at org.apache.ofbiz.base.util.collections.ResourceBundleMapWrapper.addBottomResourceBundle(ResourceBundleMapWrapper.java:94) ~[ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.AbstractModelAction$PropertyMap.runAction(AbstractModelAction.java:487) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:143) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:277) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ScreenFactory.renderReferencedScreen(ScreenFactory.java:204) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorScreen.renderWidgetString(ModelScreenWidget.java:866) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:102) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:284) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:140) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:102) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.renderer.macro.MacroScreenViewHandler.render(MacroScreenViewHandler.java:115) [ofbiz.jar:?]
        at org.apache.ofbiz.webapp.control.RequestHandler.renderView(RequestHandler.java:999) [ofbiz.jar:?]
        at org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:680) [ofbiz.jar:?]
        at org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:213) [ofbiz.jar:?]
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:686) [javax.servlet-api-4.0.0.jar:4.0.0]
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:791) [javax.servlet-api-4.0.0.jar:4.0.0]
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231) [tomcat-catalina-8.5.24.jar:8.5.24]
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) [tomcat-catalina-8.5.24.jar:8.5.24]
        at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52) [tomcat-embed-websocket-8.5.23.jar:8.5.23]
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) [tomcat-catalina-8.5.24.jar:8.5.24]
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) [tomcat-catalina-8.5.24.jar:8.5.24]
        at org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:213) [ofbiz.jar:?]
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) [tomcat-catalina-8.5.24.jar:8.5.24]
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) [tomcat-catalina-8.5.24.jar:8.5.24]
        at org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:157) [ofbiz.jar:?]
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) [tomcat-catalina-8.5.24.jar:8.5.24]
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) [tomcat-catalina-8.5.24.jar:8.5.24]
        at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:198) [tomcat-catalina-8.5.24.jar:8.5.24]
        at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96) [tomcat-catalina-8.5.24.jar:8.5.24]
        at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:504) [tomcat-catalina-8.5.24.jar:8.5.24]
        at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:140) [tomcat-catalina-8.5.24.jar:8.5.24]
        at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:81) [tomcat-catalina-8.5.24.jar:8.5.24]
        at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:87) [tomcat-catalina-8.5.24.jar:8.5.24]
        at org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:650) [tomcat-catalina-8.5.24.jar:8.5.24]
        at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:342) [tomcat-catalina-8.5.24.jar:8.5.24]
        at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:803) [tomcat-coyote-8.5.24.jar:8.5.24]
        at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66) [tomcat-coyote-8.5.24.jar:8.5.24]
        at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:790) [tomcat-coyote-8.5.24.jar:8.5.24]
        at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1459) [tomcat-coyote-8.5.24.jar:8.5.24]
        at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49) [tomcat-coyote-8.5.24.jar:8.5.24]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:1.8.0_151]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:1.8.0_151]
        at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61) [tomcat-util-8.5.24.jar:8.5.24]
        at java.lang.Thread.run(Thread.java:748) [?:1.8.0_151]
2018-01-16 15:45:48,684 |jsse-nio-8443-exec-3 |FreeMarkerWorker              |E| null
freemarker.core.InvalidReferenceException: The following has evaluated to null or missing:
==> userLogin  [in template "component://common-theme/template/includes/SetMultipleSelectJs.ftl" at line 32, column 20]

----
Tip: If the failing expression is known to legally refer to something that's sometimes null or missing, either specify a default value like myOptionalVar!myDefault, or use <#if myOptionalVar??>when-present<#else>when-missing</#if>. (These only cover the last step of the expression; to cover the whole expression, use parenthesis: (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??
----

----
FTL stack trace ("~" means nesting-related):
        - Failed at: ${userLogin.lastLocale!"en"}  [in template "component://common-theme/template/includes/SetMultipleSelectJs.ftl" at line 32, column 18]
----
{code}
Fixed at revision: 1821268  

> Replace Asm select plugin with Select2.
> ---------------------------------------
>
>                 Key: OFBIZ-10113
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10113
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>    Affects Versions: Trunk
>            Reporter: Aditya Sharma
>            Assignee: Jacques Le Roux
>            Priority: Major
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-10113.patch, OFBIZ-10113_plugins.patch, select2.tar.gz
>
>
> Current Asm Select Plugin (http://www.ryancramer.com/journal/entries/asmselect_v104/) can be replaced with Select2 (https://select2.org/).
> * Select2 has much better community support on GitHub with 386 contributors while Asm Select Plugin is handled by Ryan Cramer on http://www.ryancramer.com/.
> * Select2 has 37 releases while Asm select has very few releases yet.
> * Both the plugin has MIT license.
> Refer https://select2.org/ and  https://github.com/select2/select2 for more features and other information.

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)