[jira] [Commented] (OFBIZ-10113) Replace Asm select plugin with Select2.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-10113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16328261#comment-16328261 ]

Aditya Sharma commented on OFBIZ-10113:
---------------------------------------

Hi Jacques,

I couldn't regenerate it but as in the error message, It seems userLogin gets missing in some case. It's strange but yes we should always have valid null pointer checks even if some variable is certain. Attached a patch with valid null pointer checks.

> Replace Asm select plugin with Select2.
> ---------------------------------------
>
>                 Key: OFBIZ-10113
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10113
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>    Affects Versions: Trunk
>            Reporter: Aditya Sharma
>            Assignee: Jacques Le Roux
>            Priority: Major
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-10113.patch, OFBIZ-10113.patch, OFBIZ-10113_plugins.patch, select2.tar.gz
>
>
> Current Asm Select Plugin (http://www.ryancramer.com/journal/entries/asmselect_v104/) can be replaced with Select2 (https://select2.org/).
> * Select2 has much better community support on GitHub with 386 contributors while Asm Select Plugin is handled by Ryan Cramer on http://www.ryancramer.com/.
> * Select2 has 37 releases while Asm select has very few releases yet.
> * Both the plugin has MIT license.
> Refer https://select2.org/ and  https://github.com/select2/select2 for more features and other information.

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)