[jira] [Commented] (OFBIZ-10133) streaming large content cause out of memory exception.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-10133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16312850#comment-16312850 ]

Michael Brohl commented on OFBIZ-10133:
---------------------------------------

Mmmhh, the latest patch contains a lot of formatting changes and other bugfixes, so it's not easy to see the issue related changes.

I see some other improvements that can be done , e.g. to check for diamond operators.

Maybe better to split the patch into the core changes according to the issue and provide another patch for the formatting/refactoring on base of it and make two commits.

Else the patch looks good to me.

> streaming large content cause out of memory exception.
> ------------------------------------------------------
>
>                 Key: OFBIZ-10133
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10133
>             Project: OFBiz
>          Issue Type: Bug
>          Components: content
>    Affects Versions: Trunk
>            Reporter: Wai
>         Attachments: OFBIZ-10133.patch, OFBIZ-10133.patch, OFBIZ-10133.patch, OFBIZ-10133.patch, OFBIZ-10133.patch, OFBIZ-10133.patch, OFBIZ-10133.patch
>
>
> When ofbiz streams a large content (eg. video file), get out of memory exception.
> console output...
> 2018-01-01 05:01:03,933 |jsse-nio-8443-exec-2 |MycoReqMapHandlerBase         |E| Java heap space
> java.lang.OutOfMemoryError: Java heap space
>         at org.apache.commons.io.output.ByteArrayOutputStream.needNewBuffer(ByteArrayOutputStream.java:127) ~[commons-io-2.5.jar:2.5]
>         at org.apache.commons.io.output.ByteArrayOutputStream.write(ByteArrayOutputStream.java:158) ~[commons-io-2.5.jar:2.5]
>         at org.apache.commons.io.IOUtils.copyLarge(IOUtils.java:2147) ~[commons-io-2.5.jar:2.5]
>         at org.apache.commons.io.IOUtils.copy(IOUtils.java:2102) ~[commons-io-2.5.jar:2.5]
>         at org.apache.commons.io.IOUtils.copyLarge(IOUtils.java:2123) ~[commons-io-2.5.jar:2.5]
>         at org.apache.commons.io.IOUtils.copy(IOUtils.java:2078) ~[commons-io-2.5.jar:2.5]
>         at org.apache.commons.io.IOUtils.toByteArray(IOUtils.java:721) ~[commons-io-2.5.jar:2.5]
>  

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)