[
https://issues.apache.org/jira/browse/OFBIZ-10141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16480576#comment-16480576 ]
Jacques Le Roux commented on OFBIZ-10141:
-----------------------------------------
I agree Michael's patch is simpler. The only drawback is that the version number is hidden "deeply" in CommonRelease label and needs a running version. Where a VERSION file is easier for any user to read and when needed given (mostly to us when helping on user ML). Also changing the CommonRelease label can be forgotten, but changing the VERSION file also.
So all in all, I have no strong opinion anyway and I'd like more opinions than just Michael's and mine :D
> Add a VERSION file in root dir
> ------------------------------
>
> Key: OFBIZ-10141
> URL:
https://issues.apache.org/jira/browse/OFBIZ-10141> Project: OFBiz
> Issue Type: Improvement
> Affects Versions: Trunk
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10141.patch, OFBIZ-10141_Add_VERSION_file_simpler_solution.patch
>
>
> Following discussion at
http://markmail.org/message/ut74mzptruubw4ty we have decided to
> # have VERSION file at project root to store released version.
> # Render the version in the applications footer template as a HTML comment.
> Also [~mbrohl] suggested that
> # it can be automatically set by (custom) builds to be generated.
> # It should be made configurable in general.properties to prevent to show it if the user does not want this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Locked
