[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16869899#comment-16869899 ]
Jacques Le Roux commented on OFBIZ-10145:
-----------------------------------------
Hi Swapnil,
bq. we should also have existance check for gradle-wrapper.properties file.
I propose another change, please see below.
You are right about the Wrapper version for already installed trunk. Running something like {{gradlew wrapper --gradle-version=5.0 --distribution-type=bin}} (w/ --gradle-version changed when needed) in gradlew.bat after loading the wrapper should be enough (ie before {{@rem Execute Gradle}}.
It took 35 sec on my machine the 1st time, then it's only 1 sec. Of course when the version change that's another story, but it's then "expected". Something similar could be done for *nix version, I guess. It applies to Buildbot as well (w/o changing [ofbiz.conf file|
https://svn.apache.org/repos/infra/infrastructure/buildbot/aegis/buildmaster/master1/projects/ofbiz.conf]).
Unfortunately, I stumbled upon this [Gradle bug|
https://github.com/gradle/gradle/issues/7883] (ouch!) and I'll see later how it's possible to do better.
Here is the current state: [^gradlew.bat.patch]
About gradle-wrapper.properties check. I changed the check to verify if the gradle\wrapper directory exists, simpler ;) So we should remove this directory. That's actually what I expected when I wrote {{md %APP_HOME%\gradle\wrapper}} now replaced by {{md WRAPPER_CLASSPATH}}
> Remove the Gradle wrapper from our release packages and add a step to our build notes
> -------------------------------------------------------------------------------------
>
> Key: OFBIZ-10145
> URL:
https://issues.apache.org/jira/browse/OFBIZ-10145> Project: OFBiz
> Issue Type: Task
> Components: Gradle
> Affects Versions: 17.12.01, 16.11.06, 18.12.01
> Reporter: Jacques Le Roux
> Assignee: Nicolas Malin
> Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch, OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, gradlew.bat.patch, init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, init-gradlew-readme.patch
>
>
> Following the discussion at
http://markmail.org/message/nd7grfiyobjkfwae, considering LEGAL-288 and based on a lazy consensus on dev ML, we want to remove the gradle-wrapper.jar file from the next packaged releases and use [~jacopoc]'s related proposition to document how to have Gradle working in the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the gradle-wrapper.jar. This might change in the future (versions, etc.), so indeed maybe simply asking to download is enough, cf
https://www.google.com/search?q=gradle-wrapper.jar+download&ie=UTF-8> Also we need to add a point about removing gradle-wrapper.jar in
https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Locked
