[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16883873#comment-16883873 ]
Jacques Le Roux commented on OFBIZ-10145:
-----------------------------------------
Thanks Nicolas,
Here are [^init-gradle-wrapper.ps1] [^init-gradle-wrapper.bat]. They are simple scripts for Windows. No fancy stuff, just the bare mininum to check if the wrapper is not yet there, if not download it from ASF repo . The idea is that init-gradle-wrapper.bat should never be changed simply copied in the root of the release package with init-gradle-wrapper.ps1. This init-gradle-wrapper.ps1 contains links to R16.11 in OFBiz repo. For R17, R18, etc. Just need to change that in the URLs.
> Remove the Gradle wrapper from our release packages and add a step to our build notes
> -------------------------------------------------------------------------------------
>
> Key: OFBIZ-10145
> URL:
https://issues.apache.org/jira/browse/OFBIZ-10145> Project: OFBiz
> Issue Type: Task
> Components: Gradle
> Affects Versions: 17.12.01, 16.11.06, 18.12.01
> Reporter: Jacques Le Roux
> Assignee: Nicolas Malin
> Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch, OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch, init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.bat, init-gradle-wrapper.ps1, init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, init-gradlew-readme.patch
>
>
> Following the discussion at
http://markmail.org/message/nd7grfiyobjkfwae, considering LEGAL-288 and based on a lazy consensus on dev ML, we want to remove the gradle-wrapper.jar file from the next packaged releases and use [~jacopoc]'s related proposition to document how to have Gradle working in the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the gradle-wrapper.jar. This might change in the future (versions, etc.), so indeed maybe simply asking to download is enough, cf
https://www.google.com/search?q=gradle-wrapper.jar+download&ie=UTF-8> Also we need to add a point about removing gradle-wrapper.jar in
https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
Locked
