[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899449#comment-16899449 ]
Jacques Le Roux commented on OFBIZ-10145:
-----------------------------------------
Hi Nicolas,
Globally your patch looks good to me, at least the intent :)
It's the same that I proposed at [
https://markmail.org/message/4cdbkfm47jmcsyim:]
{quote}as a priority we should download the wrapper from Gradle "repo", and if it's not longer there, use OFBiz repo. The later would be very rare.
{quote}
It seems you did not notice that I have removed the wrappers from tools. Because they are present in releases branches and will stay there, as we agreed. They will be only removed during the RM phase. So instead of
{code:java}
RELEASE="5.0.0"
GRADLE_WRAPPER_URI="
https://github.com/gradle/gradle/raw/v$RELEASE/gradle/wrapper/"
GRADLE_WRAPPER_URI_BACKUP="
https://svn.apache.org/repos/asf/ofbiz/tools/gradle/wrapper/v$RELEASE"
{code}
you should use something like (here for R17)
{code:java}
GRADLE_RELEASE="3.2.1"
OFBIZ_RELEASE="17.12"
GRADLE_WRAPPER_URI="
https://github.com/gradle/gradle/raw/v$GRADLE_RELEASE/gradle/wrapper/"
GRADLE_WRAPPER_URI_BACKUP=
https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release$OFBIZ_RELEASE/gradle/wrapper"
{code}
Except if your idea is to copy and maintain the wrappers versions in tools, which seems not needed and more work to me ;)
> Remove the Gradle wrapper from our release packages and add a step to our build notes
> -------------------------------------------------------------------------------------
>
> Key: OFBIZ-10145
> URL:
https://issues.apache.org/jira/browse/OFBIZ-10145> Project: OFBiz
> Issue Type: Task
> Components: Gradle
> Affects Versions: 17.12.01, 16.11.06, 18.12.01
> Reporter: Jacques Le Roux
> Assignee: Nicolas Malin
> Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch, OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch, init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-with-backup-and-checksum.sh, init-gradle-wrapper.bat, init-gradle-wrapper.ps1, init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, init-gradlew-readme.patch, release-16.11-without-gradlew.patch, release-16.11-without-gradlew.patch
>
>
> Following the discussion at
http://markmail.org/message/nd7grfiyobjkfwae, considering LEGAL-288 and based on a lazy consensus on dev ML, we want to remove the gradle-wrapper.jar file from the next packaged releases and use [~jacopoc]'s related proposition to document how to have Gradle working in the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the gradle-wrapper.jar. This might change in the future (versions, etc.), so indeed maybe simply asking to download is enough, cf
https://www.google.com/search?q=gradle-wrapper.jar+download&ie=UTF-8> Also we need to add a point about removing gradle-wrapper.jar in
https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
Locked
