[
https://issues.apache.org/jira/browse/OFBIZ-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342611#comment-16342611 ]
Taher Alkhateeb commented on OFBIZ-10164:
-----------------------------------------
Thank you for the clarification. Now I understand exactly what is done. Thank you for your efforts, dedication and explanation.
The idea is nice, but I see a few problems with the implementation. Essentially, you created a splitter tag specifically designed to accommodate a jquery plugin and you've incorporated it into the common theme. The problems with this design are as follows:
* First, there is HTML related stuff in the widget (CommonScreens). It could be done with less verbosity perhaps?
* Second, the idea of a tag existing to serve specifically and be logically tied to a jquery plugin is going against the philosophy of the widget system being an independent layer from the actual view.
* You've added a tag that does not create a new structure (just add the splitter library behavior). As far as structure of the page is concerned, it is the same structure and achieved with CSS.
I would suggest that less is more. It makes more sense to make the changes purely in the common theme, and link up the CSS from the styles to the actual library without touching the core or with minimal modifications. We discussed this in the community before, and the reason we created the common-theme is to completely remove "web" related stuff from the widget system and core framework. So my recommendation is to re-design with minimal or no change to the core.
Alternatively, if you like to make this a full solution, then we can design a full splitter (vertical and horizontal) system and replace completely any old CSS styles relating to splitting with this new tag architecture. However, this might require community consensus because it would probably break some existing implementations.
The reason for my suggestion is to reduce user confusion. There should be preferably only one way to structure a page. If we have multiple ways then we are adding complexity and confusing the users of the system.
> Splitter Widget
> ---------------
>
> Key: OFBIZ-10164
> URL:
https://issues.apache.org/jira/browse/OFBIZ-10164> Project: OFBiz
> Issue Type: New Feature
> Components: framework
> Affects Versions: Trunk
> Reporter: James Yong
> Assignee: James Yong
> Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10164.patch, OFBIZ-10164.patch, OFBIZ-10164.patch, horizontal.png, vertical.png
>
>
> A new splitter widget that will use a tag named 'splitter'.
> This splitter tag has the following attributes:
> a. sizes = [25, 75] where the containers within will be splitted with a ratio of 25% and 75%
> b. parentId which is the ID of the parent container
> c. direction = vertical or horizonal (default)
> The splitter tag can only contains container(s) as immediate child.
> Using the library from
http://nathancahill.github.io/Split.js/ which is licensed under MIT license.
> Update on 20180128:
> 1) The patch comes with an example where you can view the splitter at
https://localhost:8443/catalog/control/main> 2) No need to add square brackets when defining sizes.
> 3) parentId attribute is removed,
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Locked
