[jira] [Commented] (OFBIZ-10164) Splitter Widget

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-10164) Splitter Widget

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343391#comment-16343391 ]

Jacques Le Roux commented on OFBIZ-10164:
-----------------------------------------

BTW I'm not sure it's related (did not review yet), but I was the one who introduced the drop down and asm select mechanisms (there are examples in FormWidgetExampleScreens.xml). The asmselect jQuery plugin was recently replaced by the Select2 plugin with OFBIZ-10113. There Aditya, who did most of the work, rightly suggested to refactor the asm select mechanism and created OFBIZ-10165 for that. I wonder if we could not get to an even better solution to avoid and replace the drop down and asm select mechanisms and ultimately rely on require.js to better organise things, OFBIZ-9976 was created for that. Please bear with me, I'll get back to review and see if this comment makes sense in this context...


> Splitter Widget
> ---------------
>
>                 Key: OFBIZ-10164
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10164
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: James Yong
>            Assignee: James Yong
>            Priority: Minor
>             Fix For: Trunk
>
>         Attachments: OFBIZ-10164.patch, OFBIZ-10164.patch, OFBIZ-10164.patch, horizontal.png, vertical.png
>
>
> A new splitter widget that will use a tag named 'splitter'.
> This splitter tag has the following attributes:
> a. sizes = [25, 75] where the containers within will be splitted with a ratio of 25% and 75%
> b. parentId which is the ID of the parent container
> c. direction = vertical or horizonal (default)
> The splitter tag can only contains container(s) as immediate child.
> Using the library from http://nathancahill.github.io/Split.js/ which is licensed under MIT license.
> Update on 20180128:
> 1) The patch comes with an example where you can view the splitter at https://localhost:8443/catalog/control/main
> 2) No need to add square brackets when defining sizes.
> 3) parentId attribute is removed,



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)