[jira] [Commented] (OFBIZ-10222) Access the online help in Rainbow themes

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-10222) Access the online help in Rainbow themes

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-10222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16369941#comment-16369941 ]

Jacques Le Roux commented on OFBIZ-10222:
-----------------------------------------

Thanks Julien,

Actually like most people now, I don't use IE much, but sometimes I do and by chance I stumbled upon this small issue. Now that Rainbow is the default theme, I thought it was better to fix it.
BTW I just checked and on IE+Edge is actually used as most as FF [https://en.wikipedia.org/wiki/Usage_share_of_web_browsers] This surprised me, I thought FF had still more market share :/.

About
{quote}And I found something else wrong in the previous patch...
{quote}
Actually this has already been fixed with r1824732 and related bacported commit (see my comment above)

Your fix works as far as I can tell (still OK also on FF, Chrome and Opera)

Committed inĀ 

trunk r1824847

R17.12 r1824848

R16.11 r1824849

> Access the online help in Rainbow themes
> ----------------------------------------
>
>                 Key: OFBIZ-10222
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10222
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: themes
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Assignee: Julien NICOLAS
>            Priority: Minor
>             Fix For: 17.12.01, 16.11.05
>
>         Attachments: Image 003.png, OFBIZ-10222-v2.patch, OFBIZ-10222.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)