[
https://issues.apache.org/jira/browse/OFBIZ-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16739002#comment-16739002 ]
Paul Foxworthy commented on OFBIZ-10239:
----------------------------------------
Hi [~rishisolankii] and [~aishwary],
I have encountered this issue and I think your fix is on the right track.
The transaction date is already being set for a Sales Invoice ([
https://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/accounting/minilang/ledger/GeneralLedgerServices.xml?view=markup#l2345)] and an Incoming Payment ([
https://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/accounting/minilang/ledger/GeneralLedgerServices.xml?view=markup#l1818).] and all we are trying to do is add an explicit date for other accounting transactions as well.
[~jacopoc] made a similar change for Purchase Invoices in r1658662 [
https://svn.apache.org/viewvc?view=revision&revision=1658662] in 2015.
In addition, I believe a similar change should be done for Shipment Receipts and Customer Refund Payment Applications. I have attached a new patch. What do you think?
I gather a unit test was failing on buildbot so you reverted your change. Which test? I think there might be a bug in the test.
> Improve GeneralLedgerServices to set AcctgTrans's transition date as payment's effective date
> ---------------------------------------------------------------------------------------------
>
> Key: OFBIZ-10239
> URL:
https://issues.apache.org/jira/browse/OFBIZ-10239> Project: OFBiz
> Issue Type: Improvement
> Components: accounting
> Reporter: Aishwary Shrivastava
> Assignee: Rishi Solanki
> Priority: Minor
> Attachments: OFBIZ-10239.patch
>
>
> Whenever user applies a payment, the {color:#008000}transactionDate {color}set on AcctgTransEntries is set by {color:#000080}now-timestamp{color}, this can result in wrong accounting reports, if the payment was received earlier but applied later.
> For example, if someone receives a payment on 28 of Dec and applies the payment on 3rd of Jan, the yearly accounting reports will show that transaction in the new year, rather than in the previous year.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Locked
