[
https://issues.apache.org/jira/browse/OFBIZ-10347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614800#comment-16614800 ]
Girish Vasmatkar commented on OFBIZ-10347:
------------------------------------------
Folks,
I reviewed the attached patch (OFBIZ-10347.patch) and tried to limit the changes and added some additional ones related to use of valueOf vs parseInt method. There are a couple code style changes as well. Most of the changes are related to method and variable scope.
I will take a look at more such changes and will roll them out gradually.
Any issue or concern with the changes, please let me know.
> Refactoring Variable Scope for org.apache.ofbiz.datafile
> --------------------------------------------------------
>
> Key: OFBIZ-10347
> URL:
https://issues.apache.org/jira/browse/OFBIZ-10347> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
> Affects Versions: Trunk
> Reporter: Pradhan Yash Sharma
> Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10347.patch, OFBIZ-10347_updated.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Locked
